run go vet and go test -race in CI - #118
Merged
Merged
Conversation
The Build & Test workflow only ran a Trivy scan and a goreleaser snapshot build; the test suite (including the linux-only reaper integration tests, which run fine on ubuntu runners) was never executed. Now that the tree is vet-clean (#112) and race-clean (#111), both run as a separate job in parallel with the build. Fixes #110. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a CI gate to actually execute static analysis and the Go test suite (with the race detector) so regressions are caught in GitHub Actions rather than relying on local runs.
Changes:
- Add a new
testjob to the existingBuild & Testworkflow. - Run
go vet ./...andgo test -race ./...on Ubuntu runners.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110.
The
Build & Testworkflow only ran a Trivy scan and a goreleaser snapshot build —go testwas never executed, so the test suite (including the reaper integration tests from #107 and the regression tests from #105) only ran when someone remembered to run it locally.This adds a
testjob (parallel tobuild) runninggo vet ./...andgo test -race ./.... The linux-only reaper tests (PR_SET_CHILD_SUBREAPER) run fine on ubuntu runners.Stacked on #117 (
fix/graceful-shutdown) because vet-clean (#115) and race-clean (#116) are prerequisites for these gates to pass.🤖 Generated with Claude Code