Safe filenames#8480

Draft

Amndeep7 wants to merge 15 commits into

mainfrom

Commits on Jun 24, 2026

Commits on Jun 25, 2026

modified tests to handle being concurrent better by making them independently create their tempdirs instead of generating them one at a time which could lead to race conditions when run in parallel…
Amndeep7
committed
add a test for if the target file is a symlink since resolvesafechild only checks if the intermediate directories are symlinks not the final path - this test is currently failing
Amndeep7
committed
add an additional check for if the target file is a symlink
Amndeep7
committed
converted as many locations as possible to use basename and/or resolvesafechild
Amndeep7
committed
added filename sanitization
Amndeep7
committed
add failing test for windows shell metacharacters - might need to add more characters to handle all of powershell + cmd.exe
Amndeep7
committed
Clarifies docstring for safeFilename

Amndeep7
and
Copilot
authored
rename variable to make it clearer that it's a file as opposed to a directory where the results will be saved
Amndeep7
committed
make the shell injection work properly
Amndeep7
committed

Commits on Jun 26, 2026

Commits on Jul 6, 2026