Repository navigation
chore(deps): update dependency django-aqueduct to v0.14.0 - #322
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.13.0→0.14.0Release Notes
mitodl/django-aqueduct (django-aqueduct)
v0.14.0Compare Source
Added
--openedx-plugins {lms,cms}.djangoapp— discover the settings installedOpen edX plugin apps contribute through their
plugin_settings()hooks.A plugin never assigns its settings at module scope in a module the project
names; it registers an
AppConfigunder thelms.djangoapp/cms.djangoappentry-point group and the host'scommon.pycallsadd_plugins(), which callsplugin_settings(settings)to mutate the livesettings object. Static discovery therefore produced no field for any of
them — and with an env-var source a missing field is not cosmetic:
pydantic-settings collects values per declared field, so an undeclared
MITX_REDIRECT_ENABLED=falsein the environment was dropped rather thanparsed, leaving the setting with no override path at all.
Discovery stays inside codegen v2's no-execution contract. Distribution
metadata names each plugin's
AppConfig; itsplugin_appdict is read byparsing that class's source, with the framework's constants
(
PluginSettings.CONFIG,ProjectType.LMS,SettingsType.COMMON, …)resolved from a table so the constant-reference spelling works as well as
plain string keys. The resolved settings module is then parsed for
settings.UPPERCASE = <expr>assignments insideplugin_settings(), reusingStaticModuleInspector's default capture — so literals becomeLITERAL/FACTORY, secret-looking namesREDACTED, and thesettings.ENV_TOKENS.get(...)passthrough that fills most pluginproduction.pymodules becomesDERIVED. Augmenting calls(
settings.MIDDLEWARE.extend([...])) and subscript writes are mutations of ahost-owned setting, not declarations, and are skipped.
Precedence: the project's own
--modulesalways win over a plugin field.Within a plugin,
commonis the authority for the default — under aqueductthe overlay base is
<svc>.envs.common, so that is the onlyadd_plugins()call that ever runs — and no
productionvalue displaces it, whether thatvalue is an
ENV_TOKENSpassthrough or a concrete literal.productiononlysupplies a default for a setting
commondeclares without a static value.Plugins are merged with one another only after each has been resolved
internally, so one plugin's
productionmodule cannot override another'scommondefault; a setting two different plugins both declare has no staticanswer, so the first in entry-point-name order is kept and the collision is
reported on stderr.
A plugin whose declaration cannot be read is reported on stderr and skipped
rather than failing the run. That includes a
plugin_appthe static resolvercannot interpret — built by a call, spliced with
**, or keyed by a constantoutside the framework's own — which is reported as unreadable instead of
being treated as "declares no settings" and silently dropping every field the
plugin contributes.
Also settable as
openedx_pluginsin[tool.aqueduct].DiscoveryMethod.OPENEDX_PLUGIN— provenance for the above, distinctfrom
STATICbecause the setting is never assigned in a module the projectnames.
Changed
StaticModuleInspectorlocated a module's source withimportlib.util.find_spec, which imports the module's parent packages tofind it — so resolving
some_plugin.settings.commonexecutedsome_plugin/__init__.py, breaking codegen v2's no-execution contract andallowing arbitrary third-party side effects during generation. Dotted paths
are now resolved one segment at a time against
sys.meta_path, threadingeach parent's search locations through by hand
(
django_aqueduct.discovery.static.resolve_module_source). Only the errortext changes for callers;
ImportErroris still what a module that cannotbe located raises.
Configuration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.