deps: update dependencies (major) - #17857
Open
kakkokari-gtyih wants to merge 5 commits into
Open
Conversation
dosubot
Bot
added
the
size:S
github-actions
Bot
added
packages/frontend
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughpnpmと各ワークスペースの依存関係を更新しました。キューのRedis情報取得先を変更し、 Changes依存関係メンテナンス
キュー状態契約の更新
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17857 +/- ##
============================================
+ Coverage 13.99% 26.44% +12.44%
============================================
Files 248 1177 +929
Lines 12041 40350 +28309
Branches 4036 11184 +7148
============================================
+ Hits 1685 10669 +8984
- Misses 8118 23830 +15712
- Partials 2238 5851 +3613 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -11105,8 +11105,7 @@
"wait",
"delayed",
"completed",
- "failed",
- "paused"
+ "failed"
]
}
}, |
Contributor
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (66 updated, 3 added, 3 removed)
Startup chunk size (2 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
⚙️ Backend Diagnostics ReportMemory: After GC
Only metrics showing significant changes are displayed. V8 Heap Snapshot Statistics
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/frontend/package.json (1)
81-93: 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy liftStorybook の依存関係と Storybook の追加アドオン設定を揃えてください。
.storybook/main.tsは@storybook/addon-essentials、@storybook/addon-interactions、@storybook/addon-linksを Storybook 10 の環境で有効化していますが、これらは 8.6.18、5.0.0、10.5.5 と異なっています。Storybook を 10.5.5 に揃えるなら、使用する Storybook 10 アドオン/バンドルパッケージに揃えてください。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/frontend/package.json` around lines 81 - 93, Align the Storybook dependencies in package.json with the Storybook 10.5.5 setup enabled by .storybook/main.ts: update `@storybook/addon-essentials` and `@storybook/addon-interactions` to compatible Storybook 10.5.5 versions, while keeping `@storybook/addon-links` consistent with the existing Storybook 10 dependencies.Source: MCP tools
🧹 Nitpick comments (2)
pnpm-workspace.yaml (1)
56-56: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win
minimumReleaseAgeExcludeの例外に撤去条件を追加してください。この設定は
vitest-mock-extended@5.1.1の公開直後インストールを許可します。pnpm の仕様では、除外されたパッケージは minimum release age の対象外になります。# そのうち消すだけでは撤去時期を管理できません。期限または追跡チケットを設定し、例外を恒久化しないでください。(pnpm.io)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pnpm-workspace.yaml` at line 56, Update the minimumReleaseAgeExclude entry for vitest-mock-extended@5.1.1 with a concrete removal deadline or tracking ticket reference, replacing the vague “eventually remove” note so the exception has an explicit retirement condition.Source: MCP tools
packages/frontend/package.json (1)
101-137: 🩺 Stability & Availability | 🔵 TrivialFrontend の依存関係更新後に検証を実行してください。
packages/frontend/package.jsonはビルド、Storybook、テスト、型チェックのツールを更新しています。少なくともpnpm --filter frontend testとpnpm --filter frontend build-storybookを CI で実行してください。As per path instructions,
packages/frontend/**の変更では変更範囲に最も近い検証コマンドを優先してください。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/frontend/package.json` around lines 101 - 137, After updating the frontend dependencies in packages/frontend/package.json, run the nearest validation commands in CI: pnpm --filter frontend test and pnpm --filter frontend build-storybook. Ensure both dependency-related test and Storybook build checks are included for packages/frontend changes.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/backend/src/core/QueueService.ts`:
- Line 904: Update the Redis client retrieval in the affected queue statistics
flow to use queue.getBackend().client rather than queue.backend.client, then
call client.info() and pass its result to parseRedisInfo. Preserve the existing
parsing behavior while ensuring the client is obtained through getBackend().
In `@packages/backend/src/server/api/endpoints/admin/queue/jobs.ts`:
- Line 31: admin/queue/jobs の state enum に paused を追加して、queueGetJobs
に渡される一時停止ジョブも検索できるように復元してください。意図的な仕様変更でない限り、既存の他の state 値や API
型・フロントエンドの選択肢は変更しないでください。
---
Outside diff comments:
In `@packages/frontend/package.json`:
- Around line 81-93: Align the Storybook dependencies in package.json with the
Storybook 10.5.5 setup enabled by .storybook/main.ts: update
`@storybook/addon-essentials` and `@storybook/addon-interactions` to compatible
Storybook 10.5.5 versions, while keeping `@storybook/addon-links` consistent with
the existing Storybook 10 dependencies.
---
Nitpick comments:
In `@packages/frontend/package.json`:
- Around line 101-137: After updating the frontend dependencies in
packages/frontend/package.json, run the nearest validation commands in CI: pnpm
--filter frontend test and pnpm --filter frontend build-storybook. Ensure both
dependency-related test and Storybook build checks are included for
packages/frontend changes.
In `@pnpm-workspace.yaml`:
- Line 56: Update the minimumReleaseAgeExclude entry for
vitest-mock-extended@5.1.1 with a concrete removal deadline or tracking ticket
reference, replacing the vague “eventually remove” note so the exception has an
explicit retirement condition.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 54ab5dcf-6d7d-4701-93a4-006bee873a0a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (22)
package.jsonpackages-private/changelog-checker/package.jsonpackages-private/diagnostics-backend/package.jsonpackages-private/diagnostics-frontend/package.jsonpackages-private/diagnostics-shared/package.jsonpackages/backend/package.jsonpackages/backend/src/core/QueueService.tspackages/backend/src/server/api/endpoints/admin/queue/jobs.tspackages/frontend-builder/package.jsonpackages/frontend-embed/package.jsonpackages/frontend-shared/package.jsonpackages/frontend/package.jsonpackages/frontend/src/pages/admin/job-queue.vuepackages/i18n/package.jsonpackages/icons-subsetter/package.jsonpackages/misskey-bubble-game/package.jsonpackages/misskey-js/generator/package.jsonpackages/misskey-js/package.jsonpackages/misskey-js/src/autogen/types.tspackages/misskey-reversi/package.jsonpackages/sw/package.jsonpnpm-workspace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Additional info (optional)
Checklist