Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toward #29.
Adds built-in cash channels for Eastern Asia (UN M49: 030), covering all 8 sovereign markets and administrative territories across the region:
Eastern Asian Markets
CN/CNY):cash_cn_cny— Chinese Yuan / Renminbi (People's Bank of China / Law of the People's Republic of China on the People's Bank of China, Order of the President No. 12; Regulations of the PRC on the Administration of Renminbi, State Council Decree No. 280)HK/HKD):cash_hk_hkd— Hong Kong Dollar (Hong Kong Monetary Authority / Legal Tender Notes Issue Ordinance Cap. 65; Coinage Ordinance Cap. 67; Basic Law of HKSAR Art. 111)JP/JPY):cash_jp_jpy— Japanese Yen (Bank of Japan / Bank of Japan Act, Act No. 89 of 1997, Art. 46; Currency Units and Issuance Act, Act No. 42 of 1987)KP/KPW):cash_kp_kpw— North Korean Won (Central Bank of the DPRK / Law of the DPRK on the Central Bank; Decision of the Standing Committee of the Supreme People's Assembly)KR/KRW):cash_kr_krw— South Korean Won (Bank of Korea / Bank of Korea Act, Act No. 13822, Arts. 47, 48)MN/MNT):cash_mn_mnt— Mongolian Tögrög (Bank of Mongolia / Law of Mongolia on the Central Bank, Arts. 7, 8, 9)MO/MOP):cash_mo_mop— Macanese Pataca (Monetary Authority of Macao / Decree-Law no. 7/95/M; Basic Law of Macao SAR Art. 108)TW/TWD):cash_tw_twd— New Taiwan Dollar (Central Bank of the Republic of China (Taiwan) / Central Bank Act Art. 13; Regulations for the Issuance of the New Taiwan Dollar Notes and Coins)Implementation Details
createCashPaymentChannelfactory (schemaVersion: 2,automation: PaymentChannelAutomation.None, no collection fields, standard copy/display detail rows).src/channels/<country>/cash.tsper channel conventions.src/channels/index.tsand re-exported fromsrc/index.ts.builtinPaymentChannelsand validated against completeness checks intest/payment-channels.test.mjs.registry exposes built-in cash channels for Eastern Asian markets.npm run docs:generate.Authoritative Documentation & Primary Sources
Verification
npm run check(formatter, TypeScript typecheck, docs check, examples check, and 57/57 tests pass)npm pack --dry-run(clean tarball with runtime artifacts only)npm run verify:pack(verified on isolated ESM and CommonJS consumers)