Skip to content

Add hasOption method to NodeElement class. #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kukko wants to merge 7 commits into
base: master
Choose a base branch
from
+15 −0
Open

Add hasOption method to NodeElement class. #766

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4beb120
Add hasOption method to NodeElement class.
kukko Oct 18, 2018
677797e
Changed the method description.
kukko Oct 18, 2018
dc687c4
Rewrite hasOption method to don't change value of the select.
kukko Oct 18, 2018
3a74211
Fix missing spaces.
kukko Oct 18, 2018
bf68bef
Fixing code style issues.
kukko Oct 18, 2018
7f134a1
Fix return type in documentation.
kukko Oct 18, 2018
6b3d7fe
Throw exception instead of return null.
kukko Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Element/NodeElement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,23 @@ public function selectOption($option, $multiple = false)
$this->getDriver()->selectOption($this->getXpath(), $opt->getValue(), $multiple);
}

/**
Comment thread
aik099 marked this conversation as resolved.
* Returns that the option is in the element or not.
*
* @param string $option
* @return Boolean|null
*/
public function hasOption($option)
{
if ('select' !== $this->getTagName()) {
return;

@stof stof Oct 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. It must return a boolean

@kukko kukko Oct 18, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I writed this because if the element is not a select tag, It is not logical to return a boolean. That would be nice if I throw an exception instead of return null? Or editing the documentation of method to @return Boolean|null?

@aik099 aik099 Oct 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's better to throw an exception.

}

$optionElement = $this->find('named', array('option', $option));

@aik099 aik099 Oct 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can safely inline this variable, because it's used only once.


return $optionElement !== null;
}

/**
* Checks whether current node is selected if it's a option field.
*
Expand Down