Improvements to ListEntities#6535
Open
evankanderson wants to merge 1 commit into
Open
Conversation
evankanderson
force-pushed
the
entity-list-utility
branch
from
6beee9b to
fb160ce
Compare
|
coverage: 61.296% (+0.6%) from 60.703% — evankanderson:entity-list-utility into mindersec:main |
evankanderson
commented
Jun 23, 2026
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/mock/gomock" | ||
| "golang.org/x/exp/maps" |
Member
Author
There was a problem hiding this comment.
This was fixing a lint error.
evankanderson
force-pushed
the
entity-list-utility
branch
from
fb160ce to
06b0233
Compare
…s, and report additional data
evankanderson
force-pushed
the
entity-list-utility
branch
from
06b0233 to
04ef8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ended up being a few different changes to ListEntities; four are user-visible, and one is performance-related:
Testing
Manually tested as well as adding integration tests (assisted by Gemini 3 Flash, but adjusted by hand).