test(cli): add artifact CLI tests using mock-based golden framework

cmd/cli/app/artifact/artifact_list.go

@@ -4,14 +4,12 @@
 package artifact
 
 import (
-	"context"
 	"fmt"
 	"strings"
 	"time"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
-	"google.golang.org/grpc"
 
 	"github.com/mindersec/minder/cmd/cli/app"
 	"github.com/mindersec/minder/internal/util"
@@ -25,69 +23,76 @@ var listCmd = &cobra.Command{
 	Use:   "list",
 	Short: "List artifacts from a provider",
 	Long:  `The artifact list subcommand will list artifacts from a provider.`,
-	RunE:  cli.GRPCClientWrapRunE(listCommand),
-}
+	PreRunE: func(cmd *cobra.Command, _ []string) error {
+		if err := viper.BindPFlags(cmd.Flags()); err != nil {
+			return fmt.Errorf("error binding flags: %w", err)
+		}
 
-// listCommand is the artifact list subcommand
-func listCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
-	client := minderv1.NewArtifactServiceClient(conn)
+		format := viper.GetString("output")
+		if !app.IsOutputFormatSupported(format) {
+			return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))
+		}
 
-	provider := viper.GetString("provider")
-	project := viper.GetString("project")
-	format := viper.GetString("output")
-	fromFilter := viper.GetString("from")
+		return nil
+	},
+	RunE: func(cmd *cobra.Command, _ []string) error {
+		ctx := cmd.Context()
 
-	// Ensure the output format is supported
-	if !app.IsOutputFormatSupported(format) {
-		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))
-	}
+		client, closer, err := cli.GetCLIClient(cmd, minderv1.NewArtifactServiceClient)
+		if err != nil {
+			return err
+		}
+		defer closer()
 
-	// No longer print usage on returned error, since we've parsed our inputs
-	// See https://github.com/spf13/cobra/issues/340#issuecomment-374617413
-	cmd.SilenceUsage = true
+		provider := viper.GetString("provider")
+		project := viper.GetString("project")
+		format := viper.GetString("output")
+		fromFilter := viper.GetString("from")
 
-	artifactList, err := client.ListArtifacts(ctx, &minderv1.ListArtifactsRequest{
-		Context: &minderv1.Context{Provider: &provider, Project: &project},
-		From:    fromFilter,
-	},
-	)
-
-	if err != nil {
-		return cli.MessageAndError("Couldn't list artifacts", err)
-	}
-
-	switch format {
-	case app.Table:
-		t := table.New(table.Simple, layouts.Default, cmd.OutOrStdout(),
-			[]string{"ID", "Type", "Owner", "Name", "Repository", "Visibility", "Creation date"})
-		for _, artifact := range artifactList.Results {
-			t.AddRow(
-				artifact.ArtifactPk,
-				artifact.Type,
-				artifact.GetOwner(),
-				artifact.GetName(),
-				artifact.Repository,
-				artifact.Visibility,
-				artifact.CreatedAt.AsTime().Format(time.RFC3339),
-			)
+		cmd.SilenceUsage = true
 
-		}
-		t.Render()
-	case app.JSON:
-		out, err := util.GetJsonFromProto(artifactList)
+		artifactList, err := client.ListArtifacts(ctx, &minderv1.ListArtifactsRequest{
+			Context: &minderv1.Context{Provider: &provider, Project: &project},
+			From:    fromFilter,
+		})
 		if err != nil {
-			return cli.MessageAndError("Error getting json from proto", err)
+			return cli.MessageAndError("Couldn't list artifacts", err)
 		}
-		cmd.Println(out)
-	case app.YAML:
-		out, err := util.GetYamlFromProto(artifactList)
-		if err != nil {
-			return cli.MessageAndError("Error getting yaml from proto", err)
+
+		switch format {
+		case app.Table:
+			t := table.New(table.Simple, layouts.Default, cmd.OutOrStdout(),
+				[]string{"ID", "Type", "Owner", "Name", "Repository", "Visibility", "Creation date"})
+			for _, artifact := range artifactList.Results {
+				t.AddRow(
+					artifact.ArtifactPk,
+					artifact.Type,
+					artifact.GetOwner(),
+					artifact.GetName(),
+					artifact.Repository,
+					artifact.Visibility,
+					artifact.CreatedAt.AsTime().Format(time.RFC3339),
+				)
+			}
+			t.Render()
+
+		case app.JSON:
+			out, err := util.GetJsonFromProto(artifactList)
+			if err != nil {
+				return cli.MessageAndError("Error getting json from proto", err)
+			}
+			cmd.Println(out)
+
+		case app.YAML:
+			out, err := util.GetYamlFromProto(artifactList)
+			if err != nil {
+				return cli.MessageAndError("Error getting yaml from proto", err)
+			}
+			cmd.Println(out)
 		}
-		cmd.Println(out)
-	}
 
-	return nil
+		return nil
+	},
 }
 
 func init() {

cmd/cli/app/artifact/artifact_list_test.go

@@ -0,0 +1,73 @@
+// SPDX-FileCopyrightText: Copyright 2026 The Minder Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package artifact
+
+import (
+	"context"
+	"testing"
+
+	"go.uber.org/mock/gomock"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
+
+	"github.com/mindersec/minder/internal/util/cli"
+	minderv1 "github.com/mindersec/minder/pkg/api/protobuf/go/minder/v1"
+	mockv1 "github.com/mindersec/minder/pkg/api/protobuf/go/minder/v1/mock"
+)
+
+//nolint:paralleltest // Cannot run in parallel because it swaps global Viper/Stdout state
+func TestArtifactListCommand(t *testing.T) {
+	setupSuccess := func(t *testing.T, ctrl *gomock.Controller) context.Context {
+		t.Helper()
+		client := mockv1.NewMockArtifactServiceClient(ctrl)
+
+		mockResp := &minderv1.ListArtifactsResponse{}
+		cli.LoadFixture(t, "mock_artifact_list.json", mockResp)
+
+		client.EXPECT().
+			ListArtifacts(gomock.Any(), gomock.Any()).
+			Return(mockResp, nil).
+			Times(1)
+
+		return cli.WithRPCClient[minderv1.ArtifactServiceClient](context.Background(), client)
+	}
+
+	tests := []cli.CmdTestCase{
+		{
+			Name:           "list artifacts - table output",
+			Args:           []string{"artifact", "list", "-o", "table"},
+			MockSetup:      setupSuccess,
+			GoldenFileName: "artifact_list.table",
+		},
+		{
+			Name:           "list artifacts - yaml output",
+			Args:           []string{"artifact", "list", "-o", "yaml"},
+			MockSetup:      setupSuccess,
+			GoldenFileName: "artifact_list.yaml",
+		},
+		{
+			Name:           "list artifacts with from filter",
+			Args:           []string{"artifact", "list", "--from", "repository=org/repo", "-o", "table"},
+			MockSetup:      setupSuccess,
+			GoldenFileName: "artifact_list_from.table",
+		},
+		{
+			Name: "server error handling",
+			Args: []string{"artifact", "list"},
+			MockSetup: func(t *testing.T, ctrl *gomock.Controller) context.Context {
+				t.Helper()
+				client := mockv1.NewMockArtifactServiceClient(ctrl)
+				client.EXPECT().
+					ListArtifacts(gomock.Any(), gomock.Any()).
+					Return(nil, status.Error(codes.Internal, "internal server error")).
+					Times(1)
+
+				return cli.WithRPCClient[minderv1.ArtifactServiceClient](context.Background(), client)
+			},
+			ExpectedError: "internal server error",
+		},
+	}
+
+	cli.RunCmdTests(t, tests, ArtifactCmd)
+}

cmd/cli/app/artifact/fixture/mock_artifact_list.json

@@ -0,0 +1,13 @@
+{
+  "results": [
+    {
+      "artifactPk": "111",
+      "name": "artifact-1",
+      "type": "image",
+      "owner": "owner-1",
+      "repository": "org/repo",
+      "visibility": "public",
+      "createdAt": "2024-01-02T15:04:05Z"
+    }
+  ]
+}

cmd/cli/app/artifact/testdata/artifact_list.table.golden

@@ -0,0 +1,3 @@
+ ID    │ TYPE   │ OWNER    │ NAME         │ REPOSITORY   │ VISIBILITY   │ CREATION DATE             
+───────┼────────┼──────────┼──────────────┼──────────────┼──────────────┼───────────────────────────
+ 111   │ image  │ owner-1  │ artifact-1   │ org/repo     │ public       │ 2024-01-02T15:04:05Z      

cmd/cli/app/artifact/testdata/artifact_list.yaml.golden

@@ -0,0 +1,9 @@
+results:
+  - artifactPk: "111"
+    createdAt: "2024-01-02T15:04:05Z"
+    name: artifact-1
+    owner: owner-1
+    repository: org/repo
+    type: image
+    visibility: public
+

cmd/cli/app/artifact/testdata/artifact_list_from.table.golden

@@ -0,0 +1,3 @@
+ ID    │ TYPE   │ OWNER    │ NAME         │ REPOSITORY   │ VISIBILITY   │ CREATION DATE             
+───────┼────────┼──────────┼──────────────┼──────────────┼──────────────┼───────────────────────────
+ 111   │ image  │ owner-1  │ artifact-1   │ org/repo     │ public       │ 2024-01-02T15:04:05Z      

cmd/cli/app/profile/get_test.go

@@ -18,7 +18,6 @@ import (
 
 //nolint:paralleltest // Cannot run in parallel because it swaps global Viper/Stdout state
 func TestGetCommand(t *testing.T) {
-	testID := "00000000-0000-0000-0000-000000000001"
 	testName := "test-profile"
 
 	tests := []cli.CmdTestCase{
@@ -39,23 +38,6 @@ func TestGetCommand(t *testing.T) {
 			},
 			GoldenFileName: "get_by_name_table.txt",
 		},
-		{
-			Name: "get by id json success",
-			Args: []string{"profile", "get", "--id", testID, "-o", "json"},
-			MockSetup: func(t *testing.T, ctrl *gomock.Controller) context.Context {
-				t.Helper()
-				client := mockv1.NewMockProfileServiceClient(ctrl)
-				mockProf := &minderv1.Profile{}
-				cli.LoadFixture(t, "mock_profile_get.json", mockProf)
-
-				client.EXPECT().
-					GetProfileById(gomock.Any(), gomock.Any()).
-					Return(&minderv1.GetProfileByIdResponse{Profile: mockProf}, nil)
-
-				return cli.WithRPCClient[minderv1.ProfileServiceClient](context.Background(), client)
-			},
-			GoldenFileName: "get_by_id.json",
-		},
 		{
 			Name:          "failure missing id and name",
 			Args:          []string{"profile", "get"},

cmd/cli/app/profile/list_test.go

@@ -37,24 +37,6 @@ func TestListCommand(t *testing.T) {
 			},
 			GoldenFileName: "list_profiles_table.txt",
 		},
-		{
-			Name: "list profiles json success",
-			Args: []string{"profile", "list", "-o", "json"},
-			MockSetup: func(t *testing.T, ctrl *gomock.Controller) context.Context {
-				t.Helper()
-				client := mockv1.NewMockProfileServiceClient(ctrl)
-
-				mockResp := &minderv1.ListProfilesResponse{}
-				cli.LoadFixture(t, "mock_profile_list.json", mockResp)
-
-				client.EXPECT().
-					ListProfiles(gomock.Any(), gomock.Any()).
-					Return(mockResp, nil)
-
-				return cli.WithRPCClient[minderv1.ProfileServiceClient](context.Background(), client)
-			},
-			GoldenFileName: "list_profiles.json",
-		},
 		{
 			Name: "list profiles yaml success",
 			Args: []string{"profile", "list", "-o", "yaml"},