🧪 Add e2e test for migrate namespace with multiple secret types#635
Open
Tamar-Dinavetsky wants to merge 2 commits into
Open
🧪 Add e2e test for migrate namespace with multiple secret types#635Tamar-Dinavetsky wants to merge 2 commits into
Tamar-Dinavetsky wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughAdds a reusable Kubernetes Secret verification helper and a tier1 end-to-end test covering creation, migration, application, and validation of Opaque, TLS, and docker-registry Secrets. ChangesSecret migration validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage ReportTotal: 47.8% Per-package coverage
Full function-level detailsPosted by CI |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
e2e-tests/framework/test_helpers.go (1)
99-112: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
unstructured.Unstructuredfor this secret check Replace the manualmap[string]anydecode and type assertions withunstructured.Unstructuredplus the nested access helpers; it’s the idiomatic shape for dynamic Kubernetes objects and keeps the checks safer and clearer.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@e2e-tests/framework/test_helpers.go` around lines 99 - 112, Update the secret validation logic around the JSON decode to use an unstructured.Unstructured object instead of map[string]any. Reuse its nested access helpers to read and validate the type field and data contents, preserving the existing error behavior for invalid JSON, missing or mismatched types, and empty data.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e-tests/framework/test_helpers.go`:
- Around line 93-118: Update VerifySecret so every error message includes the
Kubernetes secret namespace and secret name. For the type assertion and
expected-type mismatch checks, report the actual received value/type explicitly,
including when the field is missing or not a string, while preserving the
existing validation behavior and wrapped command/JSON errors.
---
Nitpick comments:
In `@e2e-tests/framework/test_helpers.go`:
- Around line 99-112: Update the secret validation logic around the JSON decode
to use an unstructured.Unstructured object instead of map[string]any. Reuse its
nested access helpers to read and validate the type field and data contents,
preserving the existing error behavior for invalid JSON, missing or mismatched
types, and empty data.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 65aef3e4-7fde-482e-bbdf-47774977aaa1
📒 Files selected for processing (2)
e2e-tests/framework/test_helpers.goe2e-tests/tests/tier1/mta_842_secrets_migration_test.go
Contributor
Author
|
Tested on OCP successfully. |
Contributor
Author
|
/rfr |
Tamar-Dinavetsky
added
test-automation
test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiple types (Opaque, TLS, dockerconfigjson)
types intact
cluster
Test plan
Framework changes
verifies type and data fields
Polarion: MTA-842
#502
Summary by CodeRabbit