Skip to content

Fix si_code=, si_addr=undefined. #14608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-mcmanus merged 3 commits into from
Jul 27, 2026
+15 −2
Merged

Fix si_code=, si_addr=undefined. #14608

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db0aff
Fix si_code=, si_addr=undefined.
sean-mcmanus Jul 26, 2026
248c44b
Code review feedback.
sean-mcmanus Jul 26, 2026
dc40cc9
Merge branch 'main' into seanmcm/fixEmptyUndefinedSignalInfo
sean-mcmanus Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,8 +1362,21 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr
}
if (lines[crashStackStartLine].startsWith("SIG")) {
signalType = `${lines[crashStackStartLine]}\n`;
signalInfo = `si_code=${lines[crashStackStartLine + 1]}, si_addr=${bucketSignalAddress(lines[crashStackStartLine + 2])}\n`;
crashStackStartLine += 3;
const siCodeRaw: string | undefined = lines[crashStackStartLine + 1];
const siAddrRaw: string | undefined = lines[crashStackStartLine + 2];
const siCode: string = siCodeRaw?.trim() ?? "";
const siAddr: string = siAddrRaw?.trim() ?? "";
const signalInfoParts: string[] = [];
if (siCode.length > 0) {
signalInfoParts.push(`si_code=${siCode}`);
}
if (siAddr.length > 0) {
signalInfoParts.push(`si_addr=${bucketSignalAddress(siAddr)}`);
}
signalInfo = signalInfoParts.length > 0 ? `${signalInfoParts.join(", ")}\n` : "";
// Only advance past the header lines that actually exist so a missing si_code/si_addr
// line does not cause the first stack frame to be skipped.
crashStackStartLine += 1 + (siCodeRaw !== undefined ? 1 : 0) + (siAddrRaw !== undefined ? 1 : 0);
Comment thread
sean-mcmanus marked this conversation as resolved.
} else {
// The signal type may fail to be written.
// Intentionally different from SIGUNKNOWN from cpptools,
Expand Down
Loading