Merge pasted adjacent tables - #3449
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Julia Roldi (juliaroldi)
marked this pull request as ready for review
August 24, 2026 20:30
Comment on lines
+353
to
+354
| previousBlock.rows[0]?.cells.length > 0 && | ||
| newTable.rows[0]?.cells.length > 0 |
Collaborator
There was a problem hiding this comment.
What if their cells count are different?
Contributor
Author
There was a problem hiding this comment.
Good point. At first, only the new rows were added to the end of the table, but after the model was updated, that changed the table’s appearance. I added code to expand the smaller table to match the size of the larger one.
Jiuqing Song (JiuqingSong)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge a pasted table into the table immediately before the insertion point instead of creating a separate adjacent table. The merge supports different column counts and appends the pasted rows without reapplying destination table formatting, preserving source cell border colors.
How to test
yarn test:fast --testPathPattern=mergeModelTest.