Skip to content

make it so button in project settings just says simulator theme #11582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joey Wunderlich (jwunderl) merged 1 commit into from
Sep 3, 2026
Merged

make it so button in project settings just says simulator theme #11582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions theme/pxtjson.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,4 @@
display: flex;
flex-direction: column;
gap: 0.5rem;
}

.pxt-json-simulator-theme {
display: flex;
flex-direction: column;
align-items: flex-start;
gap: 0.3rem;

label {
font-size: 14px;
font-weight: 600;
}
}
14 changes: 3 additions & 11 deletions webapp/src/pxtjson.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,6 @@ export class Editor extends srceditor.Editor {
const projectSimulatorThemePreference = accountSimulatorTheme
? simulatorTheme.getProjectSimulatorThemePreference(c.theme, simulatorThemePresets, accountSimulatorTheme)
: undefined;
const simulatorThemePresetId = projectSimulatorThemePreference?.presetId;
const hasCustomSimulatorTheme = simulatorThemePresetId === "custom";
const selectedSimulatorThemeName = !c.theme
? lf("Use account theme")
: hasCustomSimulatorTheme
? lf("Custom")
: pxt.Util.rlf(`{id:simulator-theme-name}${simulatorThemePresets.find(preset => preset.id === simulatorThemePresetId)?.name}`);

return (
<><div className="ui content">
Expand Down Expand Up @@ -269,13 +262,12 @@ export class Editor extends srceditor.Editor {
resize="vertical"
/>
}
{simulatorThemesEnabled && <div className="pxt-json-simulator-theme">
<label htmlFor="projectSimulatorTheme">{lf("Simulator theme")}</label>
{simulatorThemesEnabled && <div>
<Button
id="projectSimulatorTheme"
className="primary"
title={lf("Choose simulator theme")}
label={selectedSimulatorThemeName}
title={lf("Simulator Theme")}
label={lf("Simulator Theme")}
ariaHasPopup="dialog"
ariaExpanded={this.simulatorThemePickerOpen}
onClick={this.showSimulatorThemePicker} />
Expand Down
Loading