Skip to content

Allow deletion of unused assets #11552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Allow deletion of unused assets #11552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b628c7
Initial plan
Copilot Aug 27, 2026
d0bf1c4
Allow deletion of unused named assets
Copilot Aug 27, 2026
e6651af
Clarify block asset cleanup guard
Copilot Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pxtlib/tilemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,14 +1240,11 @@ namespace pxt {
}

function cleanupCollection<U extends Asset>(collection: AssetCollection<U>) {
const inactiveAssets = collection.getSnapshot(asset => !asset.meta.displayName && asset.meta.blockIDs?.some(id => activeBlockIDs.indexOf(id) === -1));
const inactiveAssets = collection.getSnapshot(asset => asset.meta.blockIDs?.some(id => activeBlockIDs.indexOf(id) === -1));
const toRemove: Asset[] = [];
for (const asset of inactiveAssets) {
if (asset.meta.blockIDs.length === 1) toRemove.push(asset)
else {
asset.meta.blockIDs = asset.meta.blockIDs.filter(id => activeBlockIDs.indexOf(id) !== -1);
if (asset.meta.blockIDs.length === 0) toRemove.push(asset);
}
asset.meta.blockIDs = asset.meta.blockIDs.filter(id => activeBlockIDs.indexOf(id) !== -1);
if (!asset.meta.displayName && asset.meta.blockIDs.length === 0) toRemove.push(asset);
}
for (const asset of toRemove) {
collection.removeByID(asset.id);
Expand Down
4 changes: 4 additions & 0 deletions webapp/src/components/assetEditor/assetSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ class AssetSidebarImpl extends React.Component<AssetSidebarProps, AssetSidebarSt
const project = pxt.react.getTilemapProject();
const canEdit = !isGalleryAsset;
const canCopy = asset?.type != pxt.AssetType.Tilemap && asset?.type != pxt.AssetType.Animation;
const blocksEditor = getBlocksEditor();
if (blocksEditor?.editor) {
project.removeInactiveBlockAssets(blocksEditor.editor.getAllBlocks(false).map(block => block.id));
}
const canDelete = !isGalleryAsset && !project.isAssetUsed(asset, pkg.mainEditorPkg().files);

this.setState({ canEdit, canCopy, canDelete });
Expand Down