test(webkit): CacheStorage entry should survive page.reload()#41701
Merged
Conversation
dcrousso
approved these changes
Jul 8, 2026
dgozman
approved these changes
Jul 9, 2026
Roll WebKit to r2328, which fixes CacheStorage disk persistence in persistent contexts (httpRequestHeaderFields was missing from the ResourceResponseData persistence encoder, so persisted responses failed to decode and cache.match() returned null). Add a persistent-context regression test (fixed by the roll) and an ephemeral-context test. The ephemeral case is marked as expected to fail on WebKit: an in-memory CacheStorage entry is not persisted across reload, consistent with Safari. Fixes microsoft#41618
Contributor
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky49534 passed, 1161 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpRequestHeaderFieldstoResourceResponseDatabut never to its persistence encoder, so persisted responses failed to decode andcache.match()returnednullon disk-backed (persistent) contexts — even immediately aftercache.put(). Browser fix: microsoft/playwright-browsers#2404.Fixes #41618