Fix storageState IndexedDB falsy primitive round-tripping#41697
Closed
fallintoplace wants to merge 1 commit into
Closed
Fix storageState IndexedDB falsy primitive round-tripping#41697fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Member
|
Please start with filing an issue. Also note that we are not accepting patches to this file, they should go into the browsers repo which is an open issue, #41551 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storageStateWhy
storageState({ indexedDB: true })treated serialized "trivial" values as truthy in both the collect and restore paths. That dropped valid values like0,false,'', andnull, and could also lose valid out-of-line keys like0and''.Impact
IndexedDB-backed auth and app state now round-trip correctly when records contain falsy primitive values or falsy out-of-line keys.
Testing
npm test -- tests/library/browsercontext-storage-state.spec.ts --project=chromium-library --grep "should round-trip through the file|should round-trip top-level falsy IndexedDB primitives"npx eslint packages/injected/src/storageScript.ts tests/library/browsercontext-storage-state.spec.ts