You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
browser_start_video dropped the directory part of the filename for videos recorded from additional tabs (recordings/video.webm → video-1.webm) because the numeric suffix was applied with path.basename.
Preserve path.dirname so additional tab videos land next to the first (recordings/video-1.webm).
Trying out a CI failure triage bot we're building - here's its verdict on this PR's failing checks, posting by hand for now so we can see it in context:
Hi, I'm the Playwright bot and I took a look at the failing CI.
🔴 video-start-stop fails on Windows because of this change
The 5 mcp/cli-devtools.spec.ts:217 › video-start-stop failures (all on @mcp-windows-latest-*) are caused by this PR. path.join() uses the OS separator, so on Windows the second video path comes out as recordings\video-1.webm, but the test asserts the forward-slash recordings/video-1.webm. This test passed on all 115 prior runs in the CI results DB — the only thing that changed is this PR. The other two failures are pre-existing flakes on unrelated PRs.
Details
Caused by this PR
[chrome|chromium|firefox|msedge|webkit] › mcp/cli-devtools.spec.ts:217 › video-start-stop (5×, all @mcp-windows-latest-*) — the switch to path.join(dir, path.basename(...) + suffix + ext) in backend/context.ts produces a \ separator on Windows, so the suffixed video is emitted as recordings\video-1.webm while the updated assertion expects recordings/video-1.webm. The test has never failed in 115 prior runs, and it fails on every browser on Windows — explainable everywhere, not engine-specific. Normalizing the emitted path to / (or asserting with path.sep) fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_start_videodropped the directory part of the filename for videos recorded from additional tabs (recordings/video.webm→video-1.webm) because the numeric suffix was applied withpath.basename.path.dirnameso additional tab videos land next to the first (recordings/video-1.webm).Fixes #41659