fix(playwright): separate ESM/CJS loader compilation cache entries fixes 41662#41667
Closed
ahfoysal wants to merge 1 commit into
Closed
fix(playwright): separate ESM/CJS loader compilation cache entries fixes 41662#41667ahfoysal wants to merge 1 commit into
ahfoysal wants to merge 1 commit into
Conversation
Collaborator
|
Decided to not fix this, see issue for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes cache collisions between ESM and CJS loader transforms when loading the same workspace module in both module formats.
What changed
esm\0filenamevscjs\0filename) for in-memory cache entries.getUserData()output.should keep ESM and CJS loader compilation cache separate for workspace modulesintests/playwright-test/loader.spec.tscovering globalSetup + config requiring the same workspace package.Validation
npm run -s ttest -- --grep "ESM and CJS"(not runnable here:@playwright/teststable-test-runner module missing)npm run -s tsc -- -p packages/playwright/tsconfig.json --pretty false --noEmit(not runnable here:tscunavailable without local install)Issue
Fixes #41662