[iOS] Add podspec for ListItem - #1939
Open
Alexander Boswell (alexanderboswell) wants to merge 4 commits into
Open
[iOS] Add podspec for ListItem#1939Alexander Boswell (alexanderboswell) wants to merge 4 commits into
Alexander Boswell (alexanderboswell) wants to merge 4 commits into
Conversation
Alexander Boswell (alexanderboswell)
requested a review
from a team
as a code owner
December 5, 2023 06:30
Alexander Boswell (alexanderboswell)
enabled auto-merge (squash)
December 5, 2023 06:30
Contributor
Author
|
huwilkes When I created the ListItem it seemed ideal to use the same tokens as TableViewCell. I do wonder if that doesnt make as much sense anymore because it is required for ListItem - which makes it so you have more needed (which is easy to see now when we define the podspec) Thoughts? |
Collaborator
Probably makes sense to move the tokens into their own podspec that both list item and tvc depend on rather than adding a new identical token set. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Add ListItem in the podspec file so it can be consumed.
Microsoft Reviewers: Open in CodeFlow