perf: reduce hydration target traversal overhead - #7685
Draft
Jane Chu (janechu) wants to merge 2 commits into
Draft
perf: reduce hydration target traversal overhead#7685Jane Chu (janechu) wants to merge 2 commits into
Jane Chu (janechu) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Hydration target discovery currently checks every TreeWalker candidate against a DOM Range. This change replaces that per-node Range membership work with a bounded traversal and uses the live Range only when synchronous custom-element reactions mutate the traversal boundaries.
main; Brotli output changes by +40–79 bytes.👩💻 Reviewer Notes
Please focus on the boundary-mutation fallback in
target-builder.ts. The normal path performs zero NodeFilter callbacks and zeroRange.comparePoint()calls for 107 traversal candidates; the mutation fixture uses two live-Range checks and is bounded to five in the covered scenarios.📑 Test Plan
git diff --check.✅ Checklist
General
$ npm run changeAgents