Promote the Conda ComponentDetector to experimental#1838
Open
ryanbrandenburg wants to merge 1 commit into
Open
Promote the Conda ComponentDetector to experimental#1838ryanbrandenburg wants to merge 1 commit into
ryanbrandenburg wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the CondaLock detector to the experimental lifecycle stage and wires it into the orchestrator’s experiment pipeline so telemetry/diffs can be captured while keeping experimental detector output out of normal scan results.
Changes:
- Promote
CondaLockComponentDetectorfromIDefaultOffComponentDetectortoIExperimentalDetector. - Register a new
CondaLockDetectorExperimentexperiment configuration in the orchestrator DI container. - Add a governance test and docs update to reflect the CondaLock detector’s experimental status.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Detectors.Tests/ComponentDetectorTests.cs | Adds a governance test asserting CondaLock detector is registered and implements IExperimentalDetector. |
| src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs | Registers the new CondaLock experiment configuration in DI. |
| src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/CondaLockDetectorExperiment.cs | Introduces an experiment config to compare CondaLock vs PipReport detector outputs. |
| src/Microsoft.ComponentDetection.Detectors/conda/CondaLockComponentDetector.cs | Promotes the detector to IExperimentalDetector. |
| docs/detectors/README.md | Updates detector status documentation to “Experimental”. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Low
| using YamlDotNet.Serialization; | ||
|
|
||
| public class CondaLockComponentDetector : FileComponentDetector, IDefaultOffComponentDetector | ||
| public class CondaLockComponentDetector : FileComponentDetector, IExperimentalDetector |
Contributor
Author
There was a problem hiding this comment.
This is true, and a bit odd, but it's a pre-existing condition that I'd rather fix in a separate PR after this one merges.
grvillic
approved these changes
Jul 7, 2026
grvillic
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the Conda ComponentDetector to experimental and create an experiment to start gathering telemetry so we know if this is ready for on-by-default promotion.