fix(sleep): tolerate disappearing transcript files - #285
Open
kaluli123123 wants to merge 1 commit into
Open
kaluli123123 wants to merge 1 commit into
kaluli123123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Both harvesters sorted discovered paths with a direct
os.path.getmtimecall. Live transcript stores can remove or rotate a file after directory enumeration but before sorting, allowingFileNotFoundErrorto abort the entire harvest.Changed behavior
A shared
_safe_mtimereturns a sortable fallback for paths that disappear or become inaccessible. The later transcript read remains fail-closed, so the vanished file is skipped and other sessions continue.Test plan
python3 -m unittest -q tests.test_harvest_race tests.test_harvest_pi tests.test_copilot_harvest tests.test_sleep_skill_harvest tests.test_split_wiring tests.test_holdout_integrity(48 passed)python3 -m compileall -q skillopt_sleep tests/test_harvest_race.py(passed)git diff --check(passed)The repository-required
python -m pytest -qcould not run because this environment has nopytestmodule. The OpenCode-focused unittest modules likewise require that missing dependency.Issue
Closes #284
Incomplete gates
Full pytest suite and remote CI remain maintainer/CI gates; no merge or issue close was performed locally.