Require compatible optimum-intel for OpenVINO conversion - #2650
Xiaoyu Z (xiaoyu-work) merged 3 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to optionalizing a private import, preserves existing behavior when available, and adds targeted regression coverage for both compatibility paths.
Pull request overview
This PR improves OpenVINOOptimumConversion compatibility with older optimum-intel versions by avoiding an unconditional import of the private _GPTOSSQuantizationConfig type, preventing misleading “please install optimum[openvino]” failures during import while preserving GPT-OSS behavior when available.
Changes:
- Add
_is_gptoss_quantization_confighelper to detect GPT-OSS quantization config only when the private symbol exists. - Remove the unconditional
_GPTOSSQuantizationConfigimport from the OpenVINO Optimum conversion path and gate_main_quantizeaccordingly. - Add regression tests covering both “symbol present” and “symbol absent” scenarios.
File summaries
| File | Description |
|---|---|
olive/passes/openvino/optimum_intel.py |
Makes GPT-OSS quantization type detection optional to maintain compatibility across optimum-intel versions. |
test/passes/openvino/test_openvino_optimum_conversion.py |
Adds regression tests verifying correct behavior when _GPTOSSQuantizationConfig is present or missing. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hi Sylvester Kaczmarek (@sylvesterkaczmarek), I don't think this PR is needed. We want to support the latest version for Optimum Intel, and all legacy recipes should pin the package version, so we don't need to handle compatibility issues with older versions. I would suggest adding minimum version pin here to avoid the error |
Xiaoyu Z (xiaoyu-work)
left a comment
There was a problem hiding this comment.
Update Olive required package version pin instead
|
Updated to the dependency-floor approach. OpenVINO now requires optimum-intel>=1.26.0, the first release with _GPTOSSQuantizationConfig; the test requirement matches, and the compatibility shim is removed. |
|
Xiaoyu Z (@xiaoyu-work) The current head contains only the |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
The Azure rerun did not reach the unit tests. Both Linux and Windows fail at Hugging Face login: Linux has no |
d953076
into
microsoft:main
|
Thanks for the guidance on simplifying this to the dependency-floor approach, and for the review and merge. |
Describe your changes
Fixes #2344.
OpenVINOOptimumConversionimports_GPTOSSQuantizationConfig, which was introduced in optimum-intel 1.26.0. The OpenVINO dependency set now requiresoptimum-intel>=1.26.0, and the OpenVINO test requirements use the same minimum version. This prevents an older incompatible optimum-intel release from being installed without adding a runtime compatibility shim.Tests
olive_config.jsonparses successfullygit diff --checkpasses