Skip to content

[CUDA] [PERFORMANCE] Increase speed of bf16bf16bf16_grouped_wgrad via indicating that ElementC is void / nullptr #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benediktjohannes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CUDA] [PERFORMANCE] Increase speed of bf16bf16bf16_grouped_wgrad via indicating that ElementC is void / nullptr #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions csrc/gemm/cutlass/bf16bf16bf16_grouped_wgrad/bf16bf16bf16_grouped_wgrad_common.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ at::Tensor bf16bf16bf16_grouped_wgrad_impl(
cutlass::epilogue::collective::EpilogueTileAuto,
ElementAccumulator,
ElementAccumulator,
ElementC, // Use source tensor for epilogue operations.
void,
LayoutC*,
128 / cutlass::sizeof_bits<ElementC>::value,
ElementC,
Expand Down Expand Up @@ -327,7 +327,7 @@ at::Tensor bf16bf16bf16_grouped_wgrad_impl(
{kernel_groups, problem_shape_ptr, nullptr},
{x_ptr, stride_a_ptr, w_ptr, stride_b_ptr},
{{},
(const ElementC**)output_ptr,
OUTPUT_ACCUM ? (const ElementC**)output_ptr : nullptr,
stride_c_ptr,
output_ptr,
stride_c_ptr}};
Expand Down Expand Up @@ -499,7 +499,7 @@ at::Tensor bf16bf16bf16_grouped_wgrad_sm100_impl(
cutlass::epilogue::collective::EpilogueTileAuto,
ElementAccumulator,
ElementAccumulator,
ElementC, // Use source tensor for epilogue operations.
void,
LayoutC*,
128 / cutlass::sizeof_bits<ElementC>::value,
ElementC,
Expand Down Expand Up @@ -642,7 +642,7 @@ at::Tensor bf16bf16bf16_grouped_wgrad_sm100_impl(
{kernel_groups, problem_shape_ptr, nullptr},
{x_ptr, stride_a_ptr, w_ptr, stride_b_ptr},
{{},
(const ElementC**)output_ptr,
OUTPUT_ACCUM ? (const ElementC**)output_ptr : nullptr,
stride_c_ptr,
output_ptr,
stride_c_ptr}};
Expand Down
Loading