Skip to content

fix: updated norwegian translation#291

Open
idarlund wants to merge 12 commits into
meshtastic:masterfrom
idarlund:master
Open

fix: updated norwegian translation#291
idarlund wants to merge 12 commits into
meshtastic:masterfrom
idarlund:master

Conversation

@idarlund

@idarlund idarlund commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Updated several missing translations and alphabetically sorted it to easier spot missing translations in the future

Summary by CodeRabbit

  • Localization
    • Updated Norwegian translations across the interface, including chat, themes, device settings, Wi‑Fi, backups, maps, errors, and system status.
    • Added clearer singular and plural message-count labels.
    • Expanded modem, router, filtering, reset, and node-management terminology.
    • Improved consistency for controls, locks, pins, and other UI labels.

Updated several missing translations and alphabetically sorted it to easier spot missing translations in the future
@idarlund idarlund changed the title updated norwegian translation fix: updated norwegian translation Apr 9, 2026
@idarlund

idarlund commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator Author

I have no idea to get gitleaks to ignore that false positive "generic-api-key" error:
179:19 high generic-api-key has detected secret for file locale/no.yml. gitleaks/generic-api-key

Seems like the content of .gitleaksignore should be at the format:
fingerprint:path/to/file:generic-api-key:line_number
So it should be something like xyz:locale/no.yml:generic-api-key:179, but I cannot find the fingerprint in the Trunk Check Runner log 🤔

any help would be appreciated :)

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Norwegian locale was reorganized and expanded with updated UI translations, device-role presets, pluralization, error messages, networking labels, and hardware-related strings. A corresponding .gitleaksignore entry was added for a flagged locale reference.

Changes

Norwegian locale updates

Layer / File(s) Summary
Locale header and preset structure
locale/no.yml
The initial translations and YAML block formatting were updated, and device-role presets now include revised role entries including “Router forsinket”.
Expanded Norwegian translation catalog
locale/no.yml, .gitleaksignore
UI states, counts, filters, errors, controls, networking, hardware, timing, and storage translations were added or revised; the flagged locale reference was added to .gitleaksignore.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hops through words anew,
With Norwegian labels fresh and true.
Presets bloom and errors speak,
Bright keys shine from week to week.
Gitleaks rests beneath the moon.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: updating the Norwegian translation file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locale/no.yml`:
- Line 53: Correct the malformed Norwegian translations in the locale entries:
update “Configuration Reset” entries to match the existing
“Fabrikkinnstillinger” spelling, translate “Map tiles not found!” into
Norwegian, correct the “Programmeringsmodus” spelling, and use one consistent
Norwegian “Skjermkalibrering” spelling for both screen-calibration entries.
- Line 234: Remove the trailing apostrophe from the uptime translation key so it
exactly matches `uptime 00:00:00` and lookups resolve the Norwegian translation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc5d8fba-4756-48d2-bfc6-0a770f148154

📥 Commits

Reviewing files that changed from the base of the PR and between 33917d5 and 513a47b.

📒 Files selected for processing (2)
  • .gitleaksignore
  • locale/no.yml

Comment thread locale/no.yml
Klient Gjemt
Mistet & Funnet
TAK Sporing
Configuration Reset: Farbrikkinstillinger

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Correct the remaining malformed Norwegian entries.

  • Lines 53 and 152 misspell Fabrikkinnstillinger; use the same spelling already present on line 148.
  • Line 156 remains English (Map tiles not found!).
  • Line 177 misspells Programmeringsmodus.
  • Lines 194–195 should use one Norwegian spelling, such as Skjermkalibrering; line 195 is currently Swedish.

Also applies to: 152-152, 156-156, 177-177, 194-195

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@locale/no.yml` at line 53, Correct the malformed Norwegian translations in
the locale entries: update “Configuration Reset” entries to match the existing
“Fabrikkinnstillinger” spelling, translate “Map tiles not found!” into
Norwegian, correct the “Programmeringsmodus” spelling, and use one consistent
Norwegian “Skjermkalibrering” spelling for both screen-calibration entries.

Comment thread locale/no.yml
unknown: ukjent
Unknown: Ukjent
<unset>: <ikke satt>
uptime 00:00:00': oppetid 00:00:00

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Fix the uptime message key.

The key currently includes a trailing apostrophe (uptime 00:00:00'), so lookups for uptime 00:00:00 will miss this translation.

Proposed fix
-  uptime 00:00:00': oppetid 00:00:00
+  'uptime 00:00:00': oppetid 00:00:00
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uptime 00:00:00': oppetid 00:00:00
'uptime 00:00:00': oppetid 00:00:00
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@locale/no.yml` at line 234, Remove the trailing apostrophe from the uptime
translation key so it exactly matches `uptime 00:00:00` and lookups resolve the
Norwegian translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants