fix: updated norwegian translation#291
Conversation
Updated several missing translations and alphabetically sorted it to easier spot missing translations in the future
|
I have no idea to get gitleaks to ignore that false positive "generic-api-key" error: Seems like the content of .gitleaksignore should be at the format: any help would be appreciated :) |
📝 WalkthroughWalkthroughThe Norwegian locale was reorganized and expanded with updated UI translations, device-role presets, pluralization, error messages, networking labels, and hardware-related strings. A corresponding ChangesNorwegian locale updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locale/no.yml`:
- Line 53: Correct the malformed Norwegian translations in the locale entries:
update “Configuration Reset” entries to match the existing
“Fabrikkinnstillinger” spelling, translate “Map tiles not found!” into
Norwegian, correct the “Programmeringsmodus” spelling, and use one consistent
Norwegian “Skjermkalibrering” spelling for both screen-calibration entries.
- Line 234: Remove the trailing apostrophe from the uptime translation key so it
exactly matches `uptime 00:00:00` and lookups resolve the Norwegian translation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bc5d8fba-4756-48d2-bfc6-0a770f148154
📒 Files selected for processing (2)
.gitleaksignorelocale/no.yml
| Klient Gjemt | ||
| Mistet & Funnet | ||
| TAK Sporing | ||
| Configuration Reset: Farbrikkinstillinger |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Correct the remaining malformed Norwegian entries.
- Lines 53 and 152 misspell
Fabrikkinnstillinger; use the same spelling already present on line 148. - Line 156 remains English (
Map tiles not found!). - Line 177 misspells
Programmeringsmodus. - Lines 194–195 should use one Norwegian spelling, such as
Skjermkalibrering; line 195 is currently Swedish.
Also applies to: 152-152, 156-156, 177-177, 194-195
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locale/no.yml` at line 53, Correct the malformed Norwegian translations in
the locale entries: update “Configuration Reset” entries to match the existing
“Fabrikkinnstillinger” spelling, translate “Map tiles not found!” into
Norwegian, correct the “Programmeringsmodus” spelling, and use one consistent
Norwegian “Skjermkalibrering” spelling for both screen-calibration entries.
| unknown: ukjent | ||
| Unknown: Ukjent | ||
| <unset>: <ikke satt> | ||
| uptime 00:00:00': oppetid 00:00:00 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the uptime message key.
The key currently includes a trailing apostrophe (uptime 00:00:00'), so lookups for uptime 00:00:00 will miss this translation.
Proposed fix
- uptime 00:00:00': oppetid 00:00:00
+ 'uptime 00:00:00': oppetid 00:00:00📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uptime 00:00:00': oppetid 00:00:00 | |
| 'uptime 00:00:00': oppetid 00:00:00 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locale/no.yml` at line 234, Remove the trailing apostrophe from the uptime
translation key so it exactly matches `uptime 00:00:00` and lookups resolve the
Norwegian translation.
Updated several missing translations and alphabetically sorted it to easier spot missing translations in the future
Summary by CodeRabbit