Register the Heltec RC32, RC52, and RCC6 in the device registry - #130
Conversation
Adds deviceHardware entries for the three Heltec boards whose hardware models are already reserved in the protobufs HardwareModel enum but which have no registry entry yet, so 141-143 were a gap between MESHNOLOGY_W10 and SEEED_WIO_TRACKER_L1_PRO_1W. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdded unsupported Heltec RC32, RC52, and RCC6 entries to ChangesHeltec hardware support metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This additive registry change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves a conflict in the device hardware list: the Meshnology W12 entry added on master landed at the same insertion point as the Heltec RC32/RC52/ RCC6 entries, and git aligned the two objects on their shared trailing requiresDfu/partitionScheme fields. Both sides are kept - 141-143 sit in numeric order after MESHNOLOGY_W10, and W12 keeps its position ahead of SEEED_WIO_TRACKER_L1_PRO_1W. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RC52 is the only nRF52840 board in this set, and softDeviceVariants fails closed - an absent entry is a refusal, so without this a client cannot resolve the device at all. Its firmware board definition declares s140 6.1.1 (sd_fwid 0x00B6), corroborated by its nrf52840_s140_v6.ld ldscript and consistent with every other Heltec nRF52840 entry here; the 7.3.0 entries are all Seeed/Nordic-family boards. Slotted in hwModel order between HELTEC_MESH_TOWER_V2 and SEEED_WIO_TRACKER_L1_PRO_1W. No `devices` entry: that array is the "upgrade your bootloader before OTA" advisory and applies to boards that shipped without OTA-capable bootloaders, which does not describe a new board. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adds
deviceHardwareentries for three Heltec boards, filling the 141-143 gapbetween
MESHNOLOGY_W10andSEEED_WIO_TRACKER_L1_PRO_1W.HELTEC_RC32heltec-rc32HELTEC_RC52heltec-rc52HELTEC_RCC6heltec-rcc6Field values come from each variant's
custom_meshtastic_*block in thefirmware repo. The hwModels and slugs match the reserved
HardwareModelenumvalues in protobufs master.
Also maps the RC52's SoftDevice variant in
bootloaderOtaQuirks.jsonas6.1.1, per thes140/sd_version 6.1.1its firmware board definitiondeclares.
🤖 Generated with Claude Code