Resolve opendbt_docs_projects Variable dynamically + sqlglot v30 fix - #114
Open
LexxaRRioo wants to merge 3 commits into
Open
Resolve opendbt_docs_projects Variable dynamically + sqlglot v30 fix#114LexxaRRioo wants to merge 3 commits into
LexxaRRioo wants to merge 3 commits into
Conversation
Previously projects were read once at plugin init (webserver startup), requiring a restart to pick up Variable changes. Now DBTDocsView.projects is a @Property that calls get_projects() per request. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BaseView.__init__ triggers property access, so the attribute must exist before the parent constructor runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DBTDocsView.projectsis now a@propertythat callsget_projects()per request, so changes to the Airflow Variableopendbt_docs_projectstake effect immediately without restarting the webserver.from sqlglot import Expression->from sqlglot.expressions import Expression(sqlglot v30 moved it to the submodule)._static_project_pathsis set beforesuper().__init__()becauseBaseView.__init__triggers property access.Test plan
opendbt_docs_projectsVariable in Airflow UI -> verify new project appears without restartopendbtimports cleanly with sqlglot >= 30