Repository navigation
Unbuilder the builders - #213
Merged
Merged
Conversation
charjr
force-pushed
the
unbuilder-the-builders
branch
from
September 21, 2026 16:46
1d3ef38 to
1fc15b6
Compare
charjr
marked this pull request as ready for review
September 22, 2026 11:30
Make Numeric builder an independent class
It's no longer a builder, these are internal for building processors
Since the method was a one-line lazy loader, it's simple enough to that a hook makes more sense.
charjr
force-pushed
the
unbuilder-the-builders
branch
from
September 23, 2026 12:23
c86ee68 to
b3f47d3
Compare
This is done to appease php code sniffer for now, it seems not to understand them
charjr
force-pushed
the
unbuilder-the-builders
branch
from
September 23, 2026 12:28
b3f47d3 to
1f8bc6b
Compare
carnage
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #194