Skip to content

fix(external-link): strip whitespace inside external anchors #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caugner wants to merge 2 commits into from
Open

fix(external-link): strip whitespace inside external anchors #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfdee92
fix(external-link): strip whitespace inside external anchors
caugner Sep 14, 2026
77552e4
chore(curriculum-landing): avoid stray dot
caugner Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions components/advertising/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ export class Advertising extends ServerComponent {
target="_blank"
rel="noreferrer"
class="external"
>
Mozilla's Ad targeting guidelines</a
>Mozilla's Ad targeting guidelines</a
>. We pride ourselves with an ethical advertising approach that
ensures ads are context-based, free from tracking pixels, and
don't involve personal data sharing.
Expand All @@ -95,9 +94,8 @@ export class Advertising extends ServerComponent {
target="_blank"
rel="noreferrer"
class="external"
>Join us</a
>
Join us
</a>
in this journey!
</p>
<h2>Our offering</h2>
Expand Down Expand Up @@ -125,25 +123,22 @@ export class Advertising extends ServerComponent {
target="_blank"
rel="noreferrer"
class="external"
>
this form</a
>this form</a
>, and we'll respond shortly. Discover more about
<a
href="https://www.mozilla.org/en-US/privacy/ad-targeting-guidelines/"
target="_blank"
rel="noreferrer"
class="external"
>Mozilla's Ad targeting guidelines</a
>
Mozilla's Ad targeting guidelines
</a>
and
<a
href="https://www.mozilla.org/en-US/privacy/"
target="_blank"
rel="noreferrer"
class="external"
>
Privacy policy</a
>Privacy policy</a
>.
</p>
</section>
Expand Down
5 changes: 2 additions & 3 deletions components/blog/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ export function MaybeLink(_context, { className = "", link, content }) {
class="external ${className}"
target="_blank"
rel="noreferrer"
>
${content}
</a>`
>${content}</a
>`
: html`<a href=${link} class=${className}> ${content} </a>`
: html`<span class=${className}>${content}</span>`;
}
Expand Down
8 changes: 3 additions & 5 deletions components/compat-table/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,7 @@ export class MDNCompatTable extends L10nMixin(LitElement) {
title=${this.l10n(
"compat-link-report-issue-title",
)`Report an issue with this compatibility data`}
>
${this.l10n(
>${this.l10n(
"compat-link-report-issue",
)`Report problems with this compatibility data`}</a
>${
Expand All @@ -255,9 +254,8 @@ export class MDNCompatTable extends L10nMixin(LitElement) {
filename: source_file,
},
})}
>
${this.l10n("compat-link-source")`View data on GitHub`}
</a>`
>${this.l10n("compat-link-source")`View data on GitHub`}</a
>`
: undefined
}
</div>`;
Expand Down
12 changes: 4 additions & 8 deletions components/curriculum-landing/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,8 @@ export class CurriculumLanding extends ServerComponent {
class="external"
target="_blank"
rel="noreferrer"
>
Frontend Developer Career Path
</a>
.
>Frontend Developer Career Path</a

@github-actions github-actions Bot Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing . is still on its own line, so this sentence renders as Frontend Developer Career Path ↗ . — a stray space before the period, and the period can still wrap onto its own line. Attach it to the closing bracket, matching the pattern used in components/advertising/server.js (>. We pride ourselves…):

                >Frontend Developer Career Path</a
              >.

AI-generated review by Claude

>.
</p>
</section>
</div>
Expand Down Expand Up @@ -268,9 +266,8 @@ export class CurriculumLanding extends ServerComponent {
rel="origin noreferrer"
class="external"
data-glean-id="curriculum: partner banner click"
>Scrimba's Frontend Developer Career Path</a
>
Scrimba's Frontend Developer Career Path
</a>
teaches the MDN Curriculum Core with fun interactive lessons and
challenges, knowledgeable teachers, and a supportive community. Go
from zero to landing your first front-end job!
Expand All @@ -281,9 +278,8 @@ export class CurriculumLanding extends ServerComponent {
rel="origin noreferrer"
class="external"
data-glean-id="curriculum: partner banner click"
>Find out more</a
>
Find out more
</a>
</section>

<mdn-themed-image
Expand Down
3 changes: 1 addition & 2 deletions components/footer/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,8 @@ export class Footer extends ServerComponent {
target=${link.external ? "_blank" : undefined}
rel=${link.external ? "noopener" : undefined}
data-glean-id=${`footer: link -> ${link.href}`}
>${link.text}</a
>
${link.text}
</a>
</li>
`,
)}
Expand Down
3 changes: 1 addition & 2 deletions components/observatory-results/scoring.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ export function Scoring({ result }) {
target="_blank"
rel="noreferrer"
class=${test.link.startsWith("/") ? "" : "external"}
>${test.title}</a
>
${test.title}
</a>
</td>
${
test.pass === null
Expand Down
7 changes: 3 additions & 4 deletions components/scrim-inline/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,13 @@ export class MDNScrimInline extends L10nMixin(LitElement) {
rel="origin noreferrer"
class="external"
data-glean-id="curriculum: scrim link id:${this._scrimId}"
>
<div class="scrim-link"></div>
><div class="scrim-link"></div>
<span class="visually-hidden"
>${this.l10n(
"scrim-inline-open-on-scrimba",
)`Open on Scrimba`}</span
>
</a>
></a
>
</div>
<div class="body" ${ref(this._bodyRef)}>
${
Expand Down