Use new cmdliner in tests & dev pkgs - #59
Open
mbarbin wants to merge 10 commits into
Open
Conversation
The project is getting too expensive to maintain if we want to test across all versions of upstream backend. It's been a while since cmdliner 2.0 went out, it is time to adopt it in cmdlang. Note that we still aim to support the translation to work with older versions as long as the API remains compatible. However we'll be migrating our test suite to use the latest cmdliner major version only (follow up commits).
This is a mechanical change where we promoted the new output emitted by the new version of cmdliner. There are a few more changes require which are left out of scope of that commit because they will require a bit more care, related to prefix of command and argument being no longer accepted (follow up work).
This is a tradeof: we miss some behavior of the backend, and we gain more readability and stability of the tests.
This was wasn't tracked by the incremental build but caught by the CI.
Requiring [cmdliner >= 2.1.1] in the project causes some incompatibility during CI with [bisect_ppx] whose upstream release requires [cmdliner < 2.0]. There is however a version of bisect_ppx available that is compatible with cmdliner 2.0, released to the alpha repo. This is an attempt to fix the CI jobs currently failing. [ocaml-ci] however lack support for adding opam repo so I am afraid it won't be able to be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We aim to keep the ability to translate to
cmdliner < 2.0(1.3was in used) but we'll be testing with the>= 2.1.1going forward.