cleanup(facts/docs): consolidate Fact metadata + typo fixes into one PR - #14651
cleanup(facts/docs): consolidate Fact metadata + typo fixes into one PR#14651Bartok9 wants to merge 1 commit into
Conversation
Cosmetic-only cleanup consolidating a batch of tiny fixes into one PR per maintainer request (mavlink#14649 review): - Fact shortDesc/units normalization (Hygrometer, Vibration, Wind, Battery, IMU temp, Generator runtime, ESC RPM, EFI intake manifold, Submarine rangefinder target, LocalPosition Vx) - SI unit capitalization: battery voltage v->V, hygrometer temp deg->C - Comment/doc typo fixes (Vehicle.h, BatteryIndicator.qml, font_palette, tuning_px4, QGCFlickable, QGCListView, CameraCalc image density) No functional/behavioral changes. AI-assisted; human-reviewed.
|
@DonLakeFlyer done — everything is now in this one PR and I've closed the individual tiny pulls. Sorry for the noise during your stable lockdown. All cosmetic, no behavior changes. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #14651 +/- ##
==========================================
+ Coverage 25.47% 31.55% +6.08%
==========================================
Files 769 785 +16
Lines 65912 66985 +1073
Branches 30495 31029 +534
==========================================
+ Hits 16788 21134 +4346
+ Misses 37285 31467 -5818
- Partials 11839 14384 +2545
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 454 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 0 passed, 0 failed, 0 skipped. Test Resultslinux-coverage-integration: 33 passed, 0 skipped Code CoverageCoverage: 67.8% No baseline available for comparison Artifact Sizes
Updated: 2026-07-19 19:33:21 UTC • Commit: f5daf81 • Triggered by: Android |
|
Closing remaining open work — standing down all automated coding on this repo until further notice per maintainer feedback. Thanks for your time. |
|
I'm ok with the string typos being batched together since they should not cause problems. But for now other stuff just isn't worth it yet. |
|
I'm also OK if you find some really nasty user visible bug and fix it. Just not general stuff. |
|
Thanks @DonLakeFlyer, that's a really fair line to draw and I appreciate it. Understood: I'll hold off on general cosmetic/refactor churn, and only come back with (a) a single batched string-typo PR when it's genuinely worth your time, or (b) an actual nasty user-visible bug fix if I spot one. Enjoy the stable lockdown — thanks for the patience. |
2 participants
Summary
@DonLakeFlyer — per your request on #14649, this consolidates my pile of tiny one-line changes into a single cosmetic-only PR so you don't have to manage them individually during stable lockdown.
All purely display-string / comment / doc fixes, no functional or behavioral changes:
Fact metadata (shortDesc / units normalization)
deg→C, ID label →Hygrometer IDVibe xAxis/yAxis/zAxis→Vibe X/Y/ZWind Spd→Wind Speedv→V(SI)Imu temperature→IMU temperatureruntime→RuntimeRotation Per Minute→RPMmainfold→manifold(x2)RFTarget→Rangefinder TargetVX→VxImage desity→Image densityComment / doc typos
sucessful→successfuldont→don'tthe the, tuning_px4.mdis isvertial→vertical,ListVIew→ListViewSupersedes
Closing in favor of this single PR: #14649 #14650 #14648 #14647 #14646 #14637 #14636 #14635 #14634 #14633 #14621 #14619 #14618 #14636 #14611
I intentionally dropped the
vertical munit-type changes (#14617/#14620) and the units-doc rewrite (#14599) since those are behavioral and not appropriate during stable lockdown — happy to revisit after the release.AI-assisted; human-reviewed. Thanks for the patience!