Skip to content

cleanup(facts/docs): consolidate Fact metadata + typo fixes into one PR#14651

Open
Bartok9 wants to merge 1 commit into
mavlink:masterfrom
Bartok9:consolidated-fact-metadata-cleanup
Open

cleanup(facts/docs): consolidate Fact metadata + typo fixes into one PR#14651
Bartok9 wants to merge 1 commit into
mavlink:masterfrom
Bartok9:consolidated-fact-metadata-cleanup

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

@DonLakeFlyer — per your request on #14649, this consolidates my pile of tiny one-line changes into a single cosmetic-only PR so you don't have to manage them individually during stable lockdown.

All purely display-string / comment / doc fixes, no functional or behavioral changes:

Fact metadata (shortDesc / units normalization)

  • Hygrometer: temp units degC, ID label → Hygrometer ID
  • Vibration: Vibe xAxis/yAxis/zAxisVibe X/Y/Z
  • Wind: Wind SpdWind Speed
  • Battery: voltage units vV (SI)
  • Vehicle: Imu temperatureIMU temperature
  • Generator: runtimeRuntime
  • ESC: Rotation Per MinuteRPM
  • EFI: mainfoldmanifold (x2)
  • Submarine: RFTargetRangefinder Target
  • LocalPosition: VXVx
  • CameraCalc: Image desityImage density

Comment / doc typos

  • Vehicle.h sucessfulsuccessful
  • BatteryIndicator.qml dontdon't
  • font_palette.md the the, tuning_px4.md is is
  • QGCFlickable.qml / QGCListView.qml vertialvertical, ListVIewListView

Supersedes

Closing in favor of this single PR: #14649 #14650 #14648 #14647 #14646 #14637 #14636 #14635 #14634 #14633 #14621 #14619 #14618 #14636 #14611

I intentionally dropped the vertical m unit-type changes (#14617/#14620) and the units-doc rewrite (#14599) since those are behavioral and not appropriate during stable lockdown — happy to revisit after the release.

AI-assisted; human-reviewed. Thanks for the patience!

Cosmetic-only cleanup consolidating a batch of tiny fixes into one PR
per maintainer request (mavlink#14649 review):

- Fact shortDesc/units normalization (Hygrometer, Vibration, Wind,
  Battery, IMU temp, Generator runtime, ESC RPM, EFI intake manifold,
  Submarine rangefinder target, LocalPosition Vx)
- SI unit capitalization: battery voltage v->V, hygrometer temp deg->C
- Comment/doc typo fixes (Vehicle.h, BatteryIndicator.qml, font_palette,
  tuning_px4, QGCFlickable, QGCListView, CameraCalc image density)

No functional/behavioral changes. AI-assisted; human-reviewed.
@Bartok9

Bartok9 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@DonLakeFlyer done — everything is now in this one PR and I've closed the individual tiny pulls. Sorry for the noise during your stable lockdown. All cosmetic, no behavior changes.

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.55%. Comparing base (f29efd3) to head (f5daf81).
⚠️ Report is 156 commits behind head on master.

Files with missing lines Patch % Lines
src/Vehicle/Vehicle.h 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14651      +/-   ##
==========================================
+ Coverage   25.47%   31.55%   +6.08%     
==========================================
  Files         769      785      +16     
  Lines       65912    66985    +1073     
  Branches    30495    31029     +534     
==========================================
+ Hits        16788    21134    +4346     
+ Misses      37285    31467    -5818     
- Partials    11839    14384    +2545     
Flag Coverage Δ
unittests 31.55% <0.00%> (+6.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Vehicle/Vehicle.h 68.75% <0.00%> (+28.12%) ⬆️

... and 454 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d407dd...f5daf81. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 33 passed, 0 skipped
linux-coverage-unit: 107 passed, 0 skipped
Total: 140 passed, 0 skipped

Code Coverage

Coverage: 67.8%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.83 MB
QGroundControl-aarch64 179.44 MB
QGroundControl-installer-AMD64 137.93 MB
QGroundControl-installer-AMD64-ARM64 80.46 MB
QGroundControl-installer-ARM64 109.19 MB
QGroundControl-linux 87.10 MB
QGroundControl-mac 87.09 MB
QGroundControl-windows 86.16 MB
QGroundControl-x86_64 191.65 MB
No baseline available for comparison

Updated: 2026-07-19 19:33:21 UTC • Commit: f5daf81 • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant