salvage: remove invalid isDmaBuf override (credit @Ryanf55 #14365)#14622
salvage: remove invalid isDmaBuf override (credit @Ryanf55 #14365)#14622Bartok9 wants to merge 2 commits into
Conversation
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 0 passed, 0 failed, 0 skipped. Test Resultslinux-coverage-integration: 33 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-07-19 01:15:32 UTC • Commit: 8910dad • Triggered by: Android |
a5b294c to
4956b5b
Compare
salvage: rebased of Ryanf55#14365 (credit @Ryanf55) after HwBuffers layout moved under dmabuf/. Base GstHwVideoBuffer / QHwVideoBuffer no longer declare isDmaBuf(), so override fails to compile.
4956b5b to
acb51c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14622 +/- ##
==========================================
+ Coverage 25.47% 31.53% +6.06%
==========================================
Files 769 785 +16
Lines 65912 66977 +1065
Branches 30495 31023 +528
==========================================
+ Hits 16788 21121 +4333
+ Misses 37285 31546 -5739
- Partials 11839 14310 +2471
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary
isDmaBuf() const overridefrom GstDmaBufVideoBuffer after HumBuffers path move underdmabuf/.Salvage
Rebased usefulness of @Ryanf55 #\14365 onto current
master. Original path moved; the baseGstHwVideoBuffer/QHwVideoBufferstill do not declareisDmaBuf(), sooverrideremains incorrect and trips earlier GCC paths.Motivation
Keep DMABuf GPU path header compilable against Qt multimedia private API without a phantom override.
Verification
isDmaBufgone from dmabuf header; base still has no virtualCredit
Original idea and diff intent: @Ryanf55 in #14365. This salvage re-targets the moved path only.
Notes
AI-assisted path rewrite; human-reviewed. Not bite-size-gated salvage (Daniel 2026-07-15).