Skip to content

salvage: remove invalid isDmaBuf override (credit @Ryanf55 #14365)#14622

Open
Bartok9 wants to merge 2 commits into
mavlink:masterfrom
Bartok9:aerial/salvage-14365-dmabuf-override-2026-07-17
Open

salvage: remove invalid isDmaBuf override (credit @Ryanf55 #14365)#14622
Bartok9 wants to merge 2 commits into
mavlink:masterfrom
Bartok9:aerial/salvage-14365-dmabuf-override-2026-07-17

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove non-overriding isDmaBuf() const override from GstDmaBufVideoBuffer after HumBuffers path move under dmabuf/.

Salvage

Rebased usefulness of @Ryanf55 #\14365 onto current master. Original path moved; the base GstHwVideoBuffer / QHwVideoBuffer still do not declare isDmaBuf(), so override remains incorrect and trips earlier GCC paths.

Motivation

Keep DMABuf GPU path header compilable against Qt multimedia private API without a phantom override.

Verification

  • isDmaBuf gone from dmabuf header; base still has no virtual
  • No runtime video pipeline behavior change intended (unused incorrect override)

Credit

Original idea and diff intent: @Ryanf55 in #14365. This salvage re-targets the moved path only.

Notes

AI-assisted path rewrite; human-reviewed. Not bite-size-gated salvage (Daniel 2026-07-15).

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 33 passed, 0 skipped
linux-coverage-unit: 107 passed, 0 skipped
Total: 140 passed, 0 skipped

Code Coverage

Coverage Baseline Change
67.7% 67.7% +0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 221.84 MB -4.46 MB (decrease)
QGroundControl-aarch64 179.44 MB +0.00 MB (increase)
QGroundControl-installer-AMD64 137.94 MB -0.44 MB (decrease)
QGroundControl-installer-AMD64-ARM64 80.45 MB -0.20 MB (decrease)
QGroundControl-installer-ARM64 109.22 MB +0.01 MB (increase)
QGroundControl-linux 87.10 MB -78.80 MB (decrease)
QGroundControl-mac 87.09 MB No change
QGroundControl-windows 86.16 MB No change
QGroundControl-x86_64 191.65 MB +0.00 MB (increase)
Total size decreased by 83.88 MB

Updated: 2026-07-19 01:15:32 UTC • Commit: 8910dad • Triggered by: Android

@Bartok9
Bartok9 force-pushed the aerial/salvage-14365-dmabuf-override-2026-07-17 branch from a5b294c to 4956b5b Compare July 17, 2026 20:23
salvage: rebased of Ryanf55#14365 (credit @Ryanf55) after HwBuffers layout moved under dmabuf/.
Base GstHwVideoBuffer / QHwVideoBuffer no longer declare isDmaBuf(), so override fails to compile.
@Bartok9
Bartok9 force-pushed the aerial/salvage-14365-dmabuf-override-2026-07-17 branch from 4956b5b to acb51c9 Compare July 18, 2026 20:28
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.53%. Comparing base (f29efd3) to head (8910dad).
⚠️ Report is 153 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14622      +/-   ##
==========================================
+ Coverage   25.47%   31.53%   +6.06%     
==========================================
  Files         769      785      +16     
  Lines       65912    66977    +1065     
  Branches    30495    31023     +528     
==========================================
+ Hits        16788    21121    +4333     
+ Misses      37285    31546    -5739     
- Partials    11839    14310    +2471     
Flag Coverage Δ
unittests 31.53% <ø> (+6.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 455 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6487625...8910dad. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant