Rename Call History to Phone and add a phone_call tool

[mattt]

Follow up to #157

[Copilot]

🟡 Changes recommended

Critical activation, argument-validation, and dialing-safety issues remain unresolved.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Renames Call History to Phone and adds outbound calling support.

Changes:

• Adds phone_calls_fetch and phone_call.
• Refactors call-history access.
• Updates service registration and settings.

File summaries

File	Review
App/Services/Phone.swift	Critical: activation unnecessarily requires call-history access; fetch arguments lack validation; phone-number sanitization can dial unintended recipients.
App/Services/CallHistory.swift	Removes the superseded standalone service.
App/Controllers/ServerController.swift	Registers and configures the Phone service.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Four moderate issues in Phone.swift must be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

App/Services/Phone.swift:185

• storeBookmark(for:) catches bookmark creation failures, so this method logs that access was granted and continues even though no usable bookmark exists; the immediately following fetch then fails misleadingly with noBookmarkFound (or can reuse an older bookmark). Make bookmark creation throwing and propagate the failure here before reporting success.
  App/Services/Phone.swift:402
• Any sqlite3_step result other than SQLITE_ROW is currently treated as successful completion. If stepping fails with SQLITE_BUSY, SQLITE_IOERR, or another error, this returns an empty or partial call list as a successful tool result. Check explicitly for SQLITE_DONE and throw SQLiteError for every other result.

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

Outbound calling currently accepts unsupported characters that may fail to initiate the requested call.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Balanced