Bash "safe mode" in upgrade_mattermost.sh is broken

[eric-j-ason]

docs/source/administration-guide/upgrade/upgrade_mattermost.sh

Lines 3 to 5 in 3c001a7

	# Immediately exit if a command run from a loop, a pipeline or a compound
	# command statement fails or a variable is used unset.
	set -o errexit nounset

To match the comment, the actual command should be like this:

set -o errexit -o nounset -o pipefail

This makes nounset actually take effect, and enables the pipe failure thing.

[esethna]

Bulk closing issues as our docs have migrated to the /mattermost repository. Please considering opening your issue or PR there if it is still valid.

[eric-j-ason]

@esethna: Was the file in question (upgrade_mattermost.sh) ever migrated along with the docs? I can't find it in the other repo.

[esethna]

@eric-j-ason looks like it might have been skipped as it doesn't appear in the sidebar table of contents in docs.mattermost.com. Can you tell me how you navigated to it and how you use this file?

[eric-j-ason]

If you mean how I first found the file, I don't recall. Probably, I searched for recommended ways to upgrade the Mattermost server. Is there a newer recommendation for how to do it?

I use it as part of an automated upgrade procedure. I discovered the bug when an upgrade silently failed due to some command in the script failing, but the script continuing on as if all was fine.