Skip to content

fix: preserve binary string execution semantics - #26908

Draft
ck89119 wants to merge 30 commits into
matrixorigin:mainfrom
ck89119:issue-25295-binary-execution
Draft

fix: preserve binary string execution semantics#26908
ck89119 wants to merge 30 commits into
matrixorigin:mainfrom
ck89119:issue-25295-binary-execution

Conversation

@ck89119

@ck89119 ck89119 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #25295

What this PR does / why we need it:

This is layer 3 of the replacement for draft PR #26750 and depends on layers 1 and 2.
Because the dependency branches live in a fork, this draft is temporarily cumulative against main; after the first two layers merge, only the execution/protocol/BVT commit remains.

It closes execution and protocol boundaries for binary-string provenance:

  • preserves metadata through aggregation partial state, GROUP BY/DISTINCT, projection, windows, dispatch, and remote compilation;
  • recognizes COM_STMT BLOB and long-data parameters as binary strings;
  • applies rolling-upgrade gates to shard reads and aggregate trailers;
  • adds protocol, aggregation, group, projection, window, remote execution, and BVT regressions;
  • updates the BLOB substring and binary-prefix BVT goldens.

Validation:

  • all affected frontend, shard-service, colexec, compile, and executor package tests passed;
  • embedded TestIssue25295BinaryProtocolParameterKinds passed;
  • affected-package build and vet passed;
  • make build passed;
  • CI-equivalent incremental coverage for this layer: 91.58% (185/202).

…anner

# Conflicts:
#	pkg/sql/parsers/dialect/mysql/mysql_sql.go
…cution

# Conflicts:
#	pkg/sql/compile/remoterunServer.go
#	pkg/sql/compile/remoterunServer_test.go
…anner

# Conflicts:
#	pkg/sql/parsers/dialect/mysql/mysql_sql.go
…cution

# Conflicts:
#	pkg/sql/compile/remoterunServer.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working kind/test-ci size/XXL Denotes a PR that changes 2000+ lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants