Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pkg/container/vector/functionTool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,28 @@ func TestFunctionResultAllocationSurvivesVectorTransfer(t *testing.T) {
require.Zero(t, account.Snapshot().Used)
}

func TestFunctionResultAppendMultiBytesSharesPayload(t *testing.T) {
mp := mpool.MustNewZeroNoFixed()
wrapper := NewFunctionResultWrapper(types.T_varchar.ToType(), mp)
require.NoError(t, wrapper.PreExtendAndReset(3))
result := MustFunctionResult[types.Varlena](wrapper)
payload := []byte("non-inline-payload-shared-by-every-row")

require.NoError(t, result.AppendMultiBytes(payload, false, 3))
result.AddNullAt(1)

vec := result.GetResultVector()
require.Equal(t, 3, vec.Length())
require.Len(t, vec.GetArea(), len(payload))
require.False(t, vec.VarlenaAreaIsDisjoint())
require.Equal(t, payload, vec.GetBytesAt(0))
require.True(t, vec.IsNull(1))
require.Equal(t, payload, vec.GetBytesAt(2))

wrapper.Free()
require.Zero(t, mp.CurrNB())
}

func TestAppendByteJsonUsesStorageCompatibleTypeCodes(t *testing.T) {
mp := mpool.MustNewZeroNoFixed()
wrapper := NewFunctionResultWrapper(types.T_json.ToType(), mp)
Expand Down
12 changes: 12 additions & 0 deletions pkg/container/vector/functionTools.go
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,18 @@ func (fr *FunctionResult[T]) AppendBytes(val []byte, isnull bool) error {
return nil
}

// AppendMultiBytes appends cnt logical rows backed by one materialized varlena
// payload. Non-inline descriptors intentionally share the same area range.
func (fr *FunctionResult[T]) AppendMultiBytes(val []byte, isnull bool, cnt int) error {
if !fr.vec.IsConst() {
return AppendMultiBytes(fr.vec, val, isnull, cnt, fr.mp)
}
if isnull {
return SetConstNull(fr.vec, cnt, fr.mp)
}
return SetConstBytes(fr.vec, val, cnt, fr.mp)
}

func (fr *FunctionResult[T]) AppendByteJson(bj bytejson.ByteJson, isnull bool) error {
if !fr.vec.IsConst() {
return AppendByteJson(fr.vec, bj, isnull, fr.mp)
Expand Down
Loading
Loading