fix: refresh persisted View metadata after dependency DDL - #26876
Draft
ck89119 wants to merge 19 commits into
Draft
fix: refresh persisted View metadata after dependency DDL#26876ck89119 wants to merge 19 commits into
ck89119 wants to merge 19 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
fixes #26227
What this PR does / why we need it:
View queries rebind their stored SQL against current dependencies, while
DESCandinformation_schema.columnsread the persisted ViewTableDef. Dependency DDL couldtherefore leave durable View column metadata stale even though SELECT and CTAS used the
new schema.
This change:
View schema generator;
including transitive View-of-View propagation;
View SQL, binding context, ownership, privileges, and other relation attributes;
dependencies under their binding identities;
DESCandinformation_schema.columnsfrom presenting non-current metadataas current;
Validation includes CGo package tests for all affected owners, focused and package-wide
race tests, protobuf regeneration, a fresh-instance public SQL regression, build,
go list,go vet, andgit diff --check.