fix(frontend): sync global sysvar commits across CNs - #26832
Draft
ck89119 wants to merge 14 commits into
Draft
Conversation
matrix-meow
added
size/L
matrix-meow
added
size/XL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #26793
What this PR does / why we need it:
SET GLOBALcommits the compatibility-mode row on the serving CN, but a new session routed through Proxy to another CN can still start from an older transaction snapshot and read the previous value.This change synchronizes the latest committed timestamp to every routable CN before
SET GLOBALreports success. It reuses the existingSyncCommitquery-service protocol, bounds the synchronization with a timeout, and returns partial CN failures instead of silently accepting stale cross-CN visibility.The regression tests cover timestamp propagation, response release, waiting for all CNs, partial failures, missing/unroutable dependencies, and empty commit timestamps.
Testing:
go test ./pkg/frontendgo test -race ./pkg/frontend-race -count=100go build -mod=readonly ./pkg/frontendgo vet -mod=readonly ./pkg/frontend