feat: restore filtered fulltext memory search - #232
Merged
aptend merged 1 commit intoAug 14, 2026
Conversation
loveRhythm1990
marked this pull request as ready for review
August 14, 2026 09:32
loveRhythm1990
requested review from
XuPeng-SH,
aptend and
gouhongshen
as code owners
August 14, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes
Refs #229 and restores the changes from #230.
What this PR does / why we need it
PR #230 was squash-merged as
e46ba76, but PR #228 was merged six minutes later from the same parent commit. The second squash commit replaced the first one onmain, so the full-text search implementation disappeared even though #230 remains marked as merged.This PR reapplies #230 on top of the current
main, which already contains #228, and resolves the shared-file overlap without duplicating the PythonMemory.subject_idorMemory.extra_metadatafields.POST /v1/memories/fulltext-searchbacked by MatrixOne full-text search.memories.fulltext_search()support.POST /v1/memories/queryAPI from feat: add structured memory queries #228 intact.Validation:
cargo check --manifest-path memoria/Cargo.toml -p memoria-storage -p memoria-service -p memoria-apicargo clippy --manifest-path memoria/Cargo.toml -p memoria-storage -p memoria-service -p memoria-api --lib -- -D warningscargo test --manifest-path memoria/Cargo.toml -p memoria-storage metadata_and_fulltext_validation_are_enforced_at_storage_boundarycargo test --manifest-path memoria/Cargo.toml -p memoria-api --lib fulltext_memory_type_parser_rejects_blank_entries_but_allows_empty_arrayscargo test --manifest-path memoria/Cargo.toml -p memoria-api --test api_e2e test_api_fulltext -- --nocapture(3 passed)uv run --project sdk/python pytest sdk/python/tests/unit/test_memories.py sdk/python/tests/unit/test_memories_async.py -q(89 passed)uv run --project sdk/python ruff check sdk/python/src/memoria/resources/memories.py sdk/python/tests/unit/test_memories.py sdk/python/tests/unit/test_memories_async.pygit diff --check