make sure setDefaultKeyId resolves even if no change is made - #5485
Merged
Conversation
uhoreg
force-pushed
the
setdefaultkeyid_fix_noop
branch
from
August 14, 2026 21:52
e1f8da3 to
19c5dbb
Compare
uhoreg
force-pushed
the
setdefaultkeyid_fix_noop
branch
from
August 14, 2026 22:01
19c5dbb to
5616cd2
Compare
uhoreg
marked this pull request as ready for review
August 14, 2026 22:03
florianduros
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5474
Make
setDefaultKeyIdjustsetAccountDataand return, rather than listening for the value to come back down the sync.setAccountDataalready does that now, when it actually tries to change the value, and does not make an HTTP call if we try to set the account data value to the current value, which means thatsetDefaultKeyIdwould never get notified of the value being changed (since it doesn't get changed), and so would never return.Checklist
public/exportedsymbols have accurate TSDoc documentation.