Finally drop clear RTC to-device - #5455
Open
BillCarsonFr wants to merge 2 commits into
Open
Conversation
BillCarsonFr
force-pushed
the
valere/rtc/discard_clear_to_device
branch
from
July 30, 2026 14:17
174b861 to
50703eb
Compare
BillCarsonFr
force-pushed
the
valere/rtc/discard_clear_to_device
branch
from
July 30, 2026 14:25
50703eb to
8f95e7d
Compare
BillCarsonFr
marked this pull request as ready for review
July 30, 2026 14:49
robintown
approved these changes
Aug 3, 2026
| } as unknown as MatrixEvent; | ||
| } | ||
|
|
||
| export function makeMatrixEvent( |
Member
There was a problem hiding this comment.
Any chance this can replace all usages of the above makeMockEvent?
Member
Author
There was a problem hiding this comment.
It is breaking existing tests, didn't want this PR to touch other things.
Co-authored-by: Robin <robin@robin.town>
Member
|
@BillCarsonFr is this going to land? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rust sdk widget driver is now implementing the
encryptedflag matrix-org/matrix-rust-sdk#6795It is then ok for the RTC to-device key transport to read the flag in order to ignore keys sent in clear.
This feature was already supported by the ElementWeb driver since long, so no need to synchronize release.
But for rust base client the rust-sdk must be merged before Element-Call udpates to this js-sdk change
Checklist
public/exportedsymbols have accurate TSDoc documentation.