Implement MSC4506 knock push notifications - #5425
Draft
ara4n wants to merge 2 commits into
Draft
Conversation
t3chguy
reviewed
Jul 16, 2026
Evaluates org.matrix.mscxxxx.recipient_permission (stable: recipient_permission): matches iff we (the user the rules are evaluated for) have a power level >= that required for the power-levels action named by `key`. Server-side (synapse) this drives the new default .org.matrix.mscxxxx.rule.knock override rule so users who can accept a knock are pushed; client-side support is needed because Element Web re-evaluates server-supplied rules locally via PushProcessor, which fails rules containing unknown condition kinds.
ara4n
force-pushed
the
matthew/knock-push-notifications
branch
from
July 24, 2026 01:09
597f903 to
cbb822f
Compare
t3chguy
reviewed
Jul 30, 2026
| * required to perform the `m.room.power_levels` action named by `key` | ||
| * (e.g. "invite"), in the room the event is in. | ||
| */ | ||
| private eventFulfillsRecipientPermCondition(cond: IRecipientPermissionCondition, ev: MatrixEvent): boolean { |
Member
There was a problem hiding this comment.
This should be gated behind an opt-in as it is relying on an MSC.
t3chguy
marked this pull request as draft
August 6, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets js-sdk know about push notifications for knock rules as per MSC4506, as needed for element-hq/element-web#34268