Skip to content

Update MatrixRTCSession to increase push notification arrival time on mobile clients for element-call - #5398

Open
escix wants to merge 11 commits into
matrix-org:developfrom
escix:patch-2
Open

Update MatrixRTCSession to increase push notification arrival time on mobile clients for element-call#5398
escix wants to merge 11 commits into
matrix-org:developfrom
escix:patch-2

Conversation

@escix

@escix escix commented Jul 3, 2026

Copy link
Copy Markdown

Created by Claude.

Updated the lifetime to increase the mobile push notification arrival timeout

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Updated the lifetime to increase the mobile push notification arrival timeout
@escix
escix requested a review from a team as a code owner July 3, 2026 04:24
@escix
escix requested a review from hughns July 3, 2026 04:24
@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 3, 2026

@Johennes Johennes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Your intent of increasing the notification lifetime to 60s seems reasonable. However, your changes don't appear to achieve that. Could you please fix the implementation?

@escix
escix requested a review from Johennes July 24, 2026 14:06
Comment thread src/matrixrtc/MatrixRTCSession.ts Outdated
Comment thread src/matrixrtc/MatrixRTCSession.ts Outdated
Comment thread src/matrixrtc/MatrixRTCSession.ts Outdated
Updated as per comments
@escix
escix requested a review from Johennes July 24, 2026 14:28
Comment thread src/matrixrtc/MatrixRTCSession.ts Outdated

@Johennes Johennes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests need updating.

@escix
escix requested a review from Johennes July 24, 2026 23:55
@escix escix mentioned this pull request Jul 24, 2026
4 tasks
@escix

escix commented Jul 28, 2026

Copy link
Copy Markdown
Author

Looks like the tests need updating.

@Johennes
Hi mate,
Sorry, do I need to do anything else?

@escix

escix commented Aug 1, 2026

Copy link
Copy Markdown
Author

@Johennes @hughns Hi team, can this be merged please..

escix added 2 commits August 5, 2026 09:52
It appears that element-x has increased the call ringing time to 90seconds so matching the value to that.
element-hq/element-x-android#3991
It appears that the element-x call notification has increased to 90seconds. So matching the timeout accordingly.

@escix escix left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended to match the element-x timeouts:
element-hq/element-x-android#3991

escix added 2 commits August 5, 2026 19:19
matrixrtc: restore RTC Slot support, rebase notificationLifetimeMs onto develop

@escix escix left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrixrtc: restore RTC Slot support, rebase notificationLifetimeMs onto develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Enhancement Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants