refactor(modules): move TabGroupChipsModule to dockview-core (free tier)#1414
Merged
Conversation
TabGroupChipsModule is now a free, core module rather than part of the paid dockview-enterprise bundle. The group-tab chip strip is table-stakes multi-group navigation, so gating it behind the licence watermark reads as hostile rather than an upsell. - add tabGroupChipsService.ts to dockview-core and register it in allModules.ts so it auto-registers (and fires the tab-group lifecycle events) for every component, no enterprise package required - export TabGroupChipsModule / TabGroupChipsService from dockview-core - drop it from dockview-enterprise's Modules array and explicit re-export; it stays in the enterprise public surface via `export * from 'dockview'`, so dockview-enterprise remains a drop-in superset - move the tab-group events spec into dockview-core ContextMenuModule stays enterprise (the built-in menu builder is the paid value); free users needing a tab context menu use a custom tab renderer. core 1150 / enterprise 283 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reclassifies
TabGroupChipsModulefrom pro (dockview-enterprise) to free (dockview-core). The group-tab chip strip is table-stakes multi-group navigation — gating it behind the licence watermark reads as hostile rather than an upsell.Changes
tabGroupChipsService.tstodockview-coreand register it inallModules.ts, so it auto-registers (and fires the tab-group lifecycle events) for every component with no enterprise package required.TabGroupChipsModule/TabGroupChipsServicefromdockview-core.dockview-enterprise'sModulesarray and explicit re-export. It stays in the enterprise public surface viaexport * from 'dockview', sodockview-enterpriseremains a drop-in superset.dockview-core.Notes
ContextMenuModulestays enterprise — the built-in menu builder is the paid value. Free users needing a tab context menu use a custom tab renderer (they own that DOM and can attach their owncontextmenulistener).dockview-core-only consumers: tab-group lifecycle events now fire by default (previously required the modules package). Additive.Tests
core 1150 / enterprise 283 green; both packages build clean. Core removability spec now covers the module automatically (it iterates
AllModules).🤖 Generated with Claude Code