Repository navigation
pluma-window: Fix bottom and right panels shrinking at each start - #746
Merged
Merged
Conversation
vpaned_restore_position () and hpaned_inner_restore_position () put the divider at the paned's size less the saved panel size, which leaves the panel that size less the divider's handle. On exit the panel's own size was saved, so the panel lost the size of the handle (1 px with most themes) every time pluma was started. Save the distance from the divider to the end of the paned instead, which is what the restore functions expect. Assisted-by: LLM Signed-off-by: Mintsuki <mintsuki@protonmail.com>
vkareh
approved these changes
Oct 19, 2026
vkareh
left a comment
vkareh
left a comment
Member
There was a problem hiding this comment.
I hadn't even noticed this bug before but it's there - thanks for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bottom panel gets a pixel smaller every time pluma is started, and so does the right panel. For example, with the Python Console in the bottom panel and
bottom-panel-sizeat 284, the setting reads 283, 282, 281... after each following start.vpaned_restore_position ()puts the divider at the paned's height less the saved size, which leaves the panel that size less the divider's handle, but on exit the panel's own height is saved.hpaned_inner_restore_position ()does the same for the right panel. This change saves the distance from the divider to the end of the paned instead, which is what the restore functions expect, so the stored size now includes the handle. The side panel isn't affected: it comes first in its paned, so its width is the divider's position.Tested on Arch Linux (GTK 3.24.52) with 1.28.1 and master, before and after the change, reading the panels' sizes and the saved settings after each start: