Skip to content

Simplify use of self.opts.index_errors in _deserialize #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sloria merged 1 commit into from
Jun 27, 2026
Merged

Simplify use of self.opts.index_errors in _deserialize #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/marshmallow/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,8 +620,7 @@ def _deserialize(
:return: The deserialized data as `dict_class` instance or list of `dict_class`
instances if `many` is `True`.
"""
index_errors = self.opts.index_errors
index = index if index_errors else None
index = index if self.opts.index_errors else None
if many:
if not is_sequence_but_not_string(data):
error_store.store_error([self.error_messages["type"]], index=index)
Expand Down Expand Up @@ -701,7 +700,7 @@ def getter(
error_store.store_error(
[self.error_messages["unknown"]],
key,
(index if index_errors else None),
index,
)
return ret_d

Expand Down