Skip to content

fix: make semantic status colors theme-aware - #10699

Draft
kirangadhave wants to merge 5 commits into
mainfrom
kg/load-css-next-issue
Draft

fix: make semantic status colors theme-aware#10699
kirangadhave wants to merge 5 commits into
mainfrom
kg/load-css-next-issue

Conversation

@kirangadhave

@kirangadhave kirangadhave commented Aug 29, 2026

Copy link
Copy Markdown
Member

This pull request was authored by a coding agent.

📝 Summary

Make semantic ring and status colors adapt to light and dark themes. Preserve the existing status-button fill, hover, foreground, and border contrast behind semantic tokens, and apply the primary color to native controls.

Add a real-component visual fixture with computed-style assertions and eight pinned Playwright baselines. The same Playwright container runs locally and in CI.

Closes MO-6577

Use theme-aware status colors and expose native control, success, and warning theme roles.
Replace direct Radix palette classes with theme-aware roles and cover each status variant.
Give status buttons distinct semantic fill, hover, and border roles. Assert the computed border treatment and refresh the pinned visual baselines.
@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview Aug 29, 2026 2:03am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kirangadhave kirangadhave added the internal A refactor or improvement that is not user facing label Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./frontend

Status Category Percentage Covered / Total
🔵 Lines 56.16% 20948 / 37297
🔵 Statements 56.07% 21314 / 38007
🔵 Functions 49.01% 4695 / 9579
🔵 Branches 49.48% 10766 / 21754
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/components/ui/button.tsx 65% 33.33% 100% 65% 115-123
frontend/src/css/globals.css 0% 0% 0% 0%
Generated in workflow #20885 for commit 7defb00 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user facing team-draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant