Fix/acp agent proxy remote - #10693
Open
Felipenguim wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #8531
The ACP agent panel built its WebSocket URL from a hardcoded per-agent port:
That assumes the browser can reach the agent directly. Behind a reverse proxy —
where only marimo's own port is routed — the connection never establishes, so
the agent panel is unusable in any hosted or containerized deployment.
Fixing this needs changes in th frontend and bakcend. The existing community patch (
phisignet/marimo#1)had only the frontend half, and its author noted it does not work on its own.
Both were implemented here.
Before:
browser → agent(direct, port 3017)After:
browser → marimo server (/acp/<agent_id>) → agent (127.0.0.1:<port>/message)The connection is now same-origin and only needs the port marimo is already
served on.
📋 Pre-Review Checklist
✅ Merge Checklist