Skip to content

chore(ruff): enable dictionary iteration checks - #10684

Open
Light2Dark wants to merge 2 commits into
mainfrom
t3code/enable-ruff-perf403
Open

chore(ruff): enable dictionary iteration checks#10684
Light2Dark wants to merge 2 commits into
mainfrom
t3code/enable-ruff-perf403

Conversation

@Light2Dark

@Light2Dark Light2Dark commented Aug 28, 2026

Copy link
Copy Markdown
Member

This pull request was authored by a coding agent.

📝 Summary

  • remove PERF403 and PLC0206 from the project-wide Ruff ignore list
  • replace four manual dictionary-building loops with filtered comprehensions or dict.update
  • iterate over dictionary items directly at seven sites instead of repeating indexed lookups
  • preserve filtering, insertion order, and last-write-wins behavior

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (not applicable: small internal lint cleanup).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (not applicable: no visual changes).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes (not applicable: no API changes).
  • Tests have been added for the changes made (existing focused tests cover the behavior).

🧪 Testing

  • uv run --group test pytest tests/_runtime/test_commands.py tests/_runtime/reload/test_module_watcher.py tests/_runtime/utils/test_set_ui_element_request_manager.py tests/_session/state/test_session_view.py (144 passed, 2 xpassed)
  • uv run --group test pytest tests/_ast/test_app_config.py tests/_lint/test_validate_graph.py tests/_runtime/test_executor_evaluator.py tests/_runtime/utils/test_set_ui_element_request_manager.py tests/_server/ai/test_prompts.py tests/_utils/test_deep_merge.py (85 passed)
  • make check

Written by gpt-5.6-sol on Codex

@Light2Dark Light2Dark added the internal A refactor or improvement that is not user facing label Aug 28, 2026
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview Aug 28, 2026 12:21pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

You’re at about 99% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@Light2Dark
Light2Dark requested a review from dmadisetti August 28, 2026 08:06
@Light2Dark
Light2Dark marked this pull request as ready for review August 28, 2026 08:06
@Light2Dark
Light2Dark enabled auto-merge (squash) August 28, 2026 08:06
@Light2Dark
Light2Dark requested a review from mscolnick August 28, 2026 12:18
@Light2Dark Light2Dark changed the title chore(ruff): enable dictionary comprehension check chore(ruff): enable dictionary iteration checks Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant