chore(ruff): enable dictionary iteration checks - #10684
Open
Light2Dark wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
There was a problem hiding this comment.
No issues found across 5 files
You’re at about 99% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Light2Dark
marked this pull request as ready for review
August 28, 2026 08:06
Light2Dark
enabled auto-merge (squash)
August 28, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
PERF403andPLC0206from the project-wide Ruff ignore listdict.update📋 Pre-Review Checklist
✅ Merge Checklist
🧪 Testing
uv run --group test pytest tests/_runtime/test_commands.py tests/_runtime/reload/test_module_watcher.py tests/_runtime/utils/test_set_ui_element_request_manager.py tests/_session/state/test_session_view.py(144 passed, 2 xpassed)uv run --group test pytest tests/_ast/test_app_config.py tests/_lint/test_validate_graph.py tests/_runtime/test_executor_evaluator.py tests/_runtime/utils/test_set_ui_element_request_manager.py tests/_server/ai/test_prompts.py tests/_utils/test_deep_merge.py(85 passed)make check