Skip to content

fix: preserve unqualified references in methods - #10679

Draft
dmadisetti wants to merge 2 commits into
dm/mo-7484from
dm/mo-7484-lexical-scope
Draft

fix: preserve unqualified references in methods#10679
dmadisetti wants to merge 2 commits into
dm/mo-7484from
dm/mo-7484-lexical-scope

Conversation

@dmadisetti

@dmadisetti dmadisetti commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

Followup for the comments on #10678.

We previously only had a scope distinction for comprehensions (is_comprehension), the review bots in #10678, rightly caught that because class scoping works differently from function scoping, the recursive reference calls did not work in classes.

This PR:

  • generalizes the lexical scope types
  • adds in the condition to account for the recursive call defined in classes
  • distinguished "method" from function for variable type.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview Aug 27, 2026 8:59pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

You’re at about 99% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@dmadisetti dmadisetti added the bug Something isn't working label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working team-draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant